fix: Missing properties on container file annotation #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tionsContainerFile
…rFile and add test coverage
iBotPeaches
approved these changes
Oct 13, 2025
Collaborator
iBotPeaches
left a comment
iBotPeaches
left a comment
There was a problem hiding this comment.
Thanks for clean pr that followed everything & passed CI.
I think if we dig history on type and it seems like a mistake - we can remove it in another pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
Adds the container_id and filename properties to the
OutputMessageContentOutputTextAnnotationsContainerFileclassThere is an additional discrepancy too, it appears we have "text" as a property in the codebase but this doesn't appear to be used by the API at all. I can remove this in the same PR if that's easier?
Related:
Closely related to the recently fixed issue #696, thanks @qwertyquest for making my life easier on this fix