Skip to content

fix: Missing properties on container file annotation #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2025
Merged

fix: Missing properties on container file annotation #703

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f2b825
Add missing filename property to OutputMessageContentOutputTextAnnota…
knash94 Oct 13, 2025
97d657f
Add container id to OutputMessageContentOutputTextAnnotationsContaine…
knash94 Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add missing filename property to OutputMessageContentOutputTextAnnota… 
…tionsContainerFile
  • Loading branch information
@knash94
knash94 committed Oct 13, 2025
commit 9f2b825dd97e66e2d5263fea862cdb8a5ffc299f
5 changes: 4 additions & 1 deletion src/Responses/Responses/Output/OutputMessageContentOutputTextAnnotationsContainerFile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
use OpenAI\Testing\Responses\Concerns\Fakeable;

/**
* @phpstan-type ContainerFileType array{file_id: string, type: 'container_file_citation', text?: string, start_index?: int, end_index?: int}
* @phpstan-type ContainerFileType array{file_id: string, filename: string, type: 'container_file_citation', text?: string, start_index?: int, end_index?: int}
*
* @implements ResponseContract<ContainerFileType>
*/
Expand All @@ -27,6 +27,7 @@ final class OutputMessageContentOutputTextAnnotationsContainerFile implements Re
*/
private function __construct(
public readonly string $fileId,
public readonly string $filename,
public readonly string $type,
public readonly ?string $text,
public readonly ?int $startIndex,
Expand All @@ -40,6 +41,7 @@ public static function from(array $attributes): self
{
return new self(
fileId: $attributes['file_id'],
filename: $attributes['filename'],
type: $attributes['type'],
text: $attributes['text'] ?? null,
startIndex: $attributes['start_index'] ?? null,
Expand All @@ -54,6 +56,7 @@ public function toArray(): array
{
$result = [
'file_id' => $this->fileId,
'filename' => $this->filename,
'type' => $this->type,
];

Expand Down