Skip to content

Conversation

ddaniels1
Copy link
Contributor

No description provided.

@ddaniels1 ddaniels1 closed this May 15, 2016
@ddaniels1 ddaniels1 reopened this May 15, 2016
ddaniels1 added 2 commits May 15, 2016 00:26
Number of errors when trying to intergrate autosensitvity and meal assist set up related to inconsistent use of variables. 

Using Autosensitvity doc as the "right way" to handle the variables
@@ -0,0 +1,18 @@
Set up Autosensitivity mode prior to meal assist. This includes pulling dev branch and creating the devices and modifications to reports from the basic setup that will be needed for meal assist.

Be sure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks incomplete. Did you mean to include this, or was this an aborted effort from before you decided to consolidate them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes abort it

Sent from my iphone
Excuse the typos

On May 15, 2016, at 5:33 PM, Scott Leibrand [email protected] wrote:

In docs/docs/walkthrough/phase-6/Configuring Meal Assist:

@@ -0,0 +1,18 @@
+Set up Autosensitivity mode prior to meal assist. This includes pulling dev branch and creating the devices and modifications to reports from the basic setup that will be needed for meal assist.
+
+Be sure
This looks incomplete. Did you mean to include this, or was this an aborted effort from before you decided to consolidate them?


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub

@scottleibrand
Copy link
Contributor

Added some line notes. There are some other improvements we could make, such as giving people actual commands to run instead of making them edit .ini files, but this is a whole heck of a lot better than nothing, and definitely worth merging ASAP after fixing the few nits I noted. Thanks!

@ddaniels1
Copy link
Contributor Author

Ok will work on it tonight

Sent from my iphone
Excuse the typos

On May 15, 2016, at 5:36 PM, Scott Leibrand [email protected] wrote:

Added some line notes. There are some other improvements we could make, such as giving people actual commands to run instead of making them edit .ini files, but this is a whole heck of a lot better than nothing, and definitely worth merging ASAP after fixing the few nits I noted. Thanks!


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub

@scottleibrand
Copy link
Contributor

If you'd prefer I can merge and then fix those things in dev.

-Scott

On Sun, May 15, 2016 at 7:25 PM, ddaniels1 [email protected] wrote:

Ok will work on it tonight

Sent from my iphone
Excuse the typos

On May 15, 2016, at 5:36 PM, Scott Leibrand [email protected]
wrote:

Added some line notes. There are some other improvements we could make,
such as giving people actual commands to run instead of making them edit
.ini files, but this is a whole heck of a lot better than nothing, and
definitely worth merging ASAP after fixing the few nits I noted. Thanks!


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#166 (comment)

@ddaniels1
Copy link
Contributor Author

Let me try to do it, gives me a better understanding of things to have to explain it. Going to try to start setting up Edison and ti stick tonight. I have all the gear. Any advice beyond what's in the wiki?

Sent from my iphone
Excuse the typos

On May 15, 2016, at 7:27 PM, Scott Leibrand [email protected] wrote:

If you'd prefer I can merge and then fix those things in dev.

-Scott

On Sun, May 15, 2016 at 7:25 PM, ddaniels1 [email protected] wrote:

Ok will work on it tonight

Sent from my iphone
Excuse the typos

On May 15, 2016, at 5:36 PM, Scott Leibrand [email protected]
wrote:

Added some line notes. There are some other improvements we could make,
such as giving people actual commands to run instead of making them edit
.ini files, but this is a whole heck of a lot better than nothing, and
definitely worth merging ASAP after fixing the few nits I noted. Thanks!


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#166 (comment)


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub

@scottleibrand
Copy link
Contributor

Not really, except not to be afraid to ask questions in Gitter the moment you get stuck.

@ddaniels1
Copy link
Contributor Author

K thanks. I heard the range is better than the carelink. Really want to be able to keep her rig with us in a fanny and allow her to loop during the day. She is pretty small even to carry the pump.

Sent from my iphone
Excuse the typos

On May 15, 2016, at 7:36 PM, Scott Leibrand [email protected] wrote:

Not really, except not to be afraid to ask questions in Gitter the moment you get stuck.


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub

@danamlewis
Copy link
Contributor

(Waiting to review for the updates, but overall this is looking good, so as soon as recommended updates are made we can merge!)

@scottleibrand
Copy link
Contributor

Any objections to merging this now so someone else can fix the remaining things?

@danamlewis
Copy link
Contributor

That's fine as long as you make a note that it's known to need further
fixing after it is in.

On Wednesday, May 18, 2016, Scott Leibrand [email protected] wrote:

Any objections to merging this now so someone else can fix the remaining
things?


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#166 (comment)

Dana Lewis | http://www.twitter.com/danamlewis |
http://www.linkedin.com/in/danalewis
"Doing something for someone else is more important than anything you would
do for yourself."

@scottleibrand scottleibrand merged commit e0512b5 into openaps:dev May 19, 2016
@ddaniels1
Copy link
Contributor Author

No problem to go ahead and merge, I will try to get back to it soon myself,
just caught with trying to set up the TI now

On Wed, May 18, 2016 at 8:25 PM, Dana Lewis [email protected]
wrote:

That's fine as long as you make a note that it's known to need further
fixing after it is in.

On Wednesday, May 18, 2016, Scott Leibrand [email protected]
wrote:

Any objections to merging this now so someone else can fix the remaining
things?


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#166 (comment)

Dana Lewis | http://www.twitter.com/danamlewis |
http://www.linkedin.com/in/danalewis
"Doing something for someone else is more important than anything you would
do for yourself."


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#166 (comment)

David V. Daniels, MD
PAMF Interventional Cardiology

C - 415-385-9243

scottleibrand added a commit that referenced this pull request May 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants