Remove Unused oref0 dexusb cgm loop #1086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@PieterGit, does the PR accomplish your suggestion in #1085 ? |
Contributor
|
yes, looks good. i'll test it as well. |
PieterGit
approved these changes
Aug 19, 2018
Contributor
PieterGit
left a comment
PieterGit
left a comment
There was a problem hiding this comment.
looks good, tested install on Edison Explorer Board and works. @scottleibrand I think this can be merged to dev for the 0.7.0 release
Contributor
|
Some history/background. This script from created and used in the < 0.6.0 days (which used quite some more Python than nowadays). This used to work similar to the |
This was referenced Aug 19, 2018
scottleibrand
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
G4-Go script is much better than the old bin/oref0-dexusb-cgm-loop.py script.