various fixes (mainly WW related) from fresh edison/rpi0 install #1087

PieterGit · 2018-08-19T22:48:33Z

also incorpates @jpcunningh Independent mmtune script #1085 and Remove Unused oref0 dexusb cgm loop #1086 (sorry for not seperating my PR and @jpcunningh 's)
fixes a problem with WW pumps that the radio_locale is not in the pump.ini. Also reported by @cluckj on https://gitter.im/openaps/oref0?at=5b78b34a802bc42c5f3b4870
fixes a nasty issue with timeouts with pip3/pip packages, see Timeout issues with pip or pip3: TypeError: unsupported operand type(s) for -=: 'Retry' and 'int' #1095
upgrade to node 8.11.4 and thus npm 5.6.0

Work in progress / do not merge yet.

The uploading of cgm data with G4-go does not work for me with tokenbased authentication. Working on that.

@scottleibrand can you do a review so far?

…add npm shrinkwrap

- upgrade bluez to 5.50 (if < 5.43 is available) - remove spaces at the end of lines - auto install bluez-tools (add -y flag)

- show latests versions of ecc1 libraries as example - remove duplicate buildgofromsource line - fix .profile warning - use Mhz notation for medtronic_frequency.ini

…grade

you should instead use G4-Go which is much better alternative

use G4-Go instead

only ask for ww_ti_usb_edison on non edison hardware append radio_locale to pump.ini

the other find gave an empty set on edison

jpcunningh · 2018-08-19T22:53:04Z

@PieterGit, will you incorporate the changes youn requested in this PR such that I should close the other 2 PRs?

Thanks!

…s openaps environment.

- the autotune did not list the time of execution. added - autotune requires en_US.UTF-8 locale. This is not installed on a fresh edison. Install it if autotune is enabled.

…grade

scottleibrand

A few comments inline.

scottleibrand · 2018-08-20T17:31:12Z

bin/oref0-cron-every-minute.sh

 # if the rig doesn't recover after that, reboot:
-oref0-radio-reboot &
+# DEPRECATED WITH 0.7.0. See if we can do without
+# oref0-radio-reboot &


No, this wasn't deprecated: I re-enabled it for 0.7.0 with commit de462de

i see a lot of radio reboots with the 0.7.0 that seem unnecessary and cause interruption during normal pump-rig comms. if it's really needed in some corner cases perhaps move to every 15 minutes? I would like to make it configurable and see if I can do without these reboots. I think there is still some other issue that makes rebooting without network not boot up the rig without problems.

It would be better to lengthen the delay before reboot so it has slightly longer to start making progress and cancel the scheduled reboot.

only lengthen the delay will keep a lot of false positives (that hopefully will be cancelled in time). previouse mmweowlink and pump comms could really be messed up after a reboot. I rather see if we can minimize the amount of reboots, perhaps only make them as an option.

How about testing it every 15 minutes and upping the reboot time to 10 minutes. That would give a minimum of 10 minutes and max of 25 minutes in case of pump-rig comms failures. Thoughts?

I've never seen any issues caused by a reboot: can you provide more specifics on what problems you've seen as a result of rebooting a 0.7.0 rig?

I'd rather not wait 25 minutes to start looping again if the rig gets into a bad state. I'm ok with a few extra log messages about scheduled reboots that get canceled before occurring: those don't do any harm, and if someone is looking at their logs closely enough to notice them, they might point to an underlying issue...

@scottleibrand
Issues I know of are:

older explorer boards have issues with Dexcom G4 USB and the micro usb needs to be inserted after reboot

edison does not have RTC and during systemstartup internet connection is required in order to set the right time. We should make sure the time from the pump is used in those cases, but that doesn't completely work (yet)

Another reason is that rebooting in case of an issue instead of fixing the root cause is a Microsoft way of doing stuff.

Can we agree on:

making reboot configurable

let's try to disable it by default and see if the current 0.7.x codebase has issues that resolve if you reboot the rig

try to resolve those issues, instead of rebooting

people who enable the setting should check if the 0.7.0-dev rig reboots in common daily use

before 0.7.x release decide if we need to use enable reboot by default

scottleibrand · 2018-08-20T17:33:27Z

package.json

    "moment": "^2.14.1",
    "request": "^2.79.0",
-    "share2nightscout-bridge": "^0.1.5",
+    "share2nightscout-bridge": "git://github.com/nightscout/share2nightscout-bridge.git#wip/generalize",


What does this do?

This is the version Nightscout uses. We should re publish a new NPM package. I tried contacting Ben West, but didn't get a response.
For a list of changes see https://github.com/nightscout/share2nightscout-bridge/commits/wip/generalize
It fixes a security issue.

scottleibrand · 2018-08-20T17:33:37Z

npm-shrinkwrap.json

+      }
+    }
+  }
+}


Was this added intentionally?

yes, adding a npm-shrinkwrap.json makes package integrity better.

Does npm update it automatically and create merge conflicts? Or is it maintained manually?

it's changed with the npm commands. i did not have a lot of merge conflicts with it for nightscout. In case you have merge problems, you always re-create it with npm shrinkwrap

The problem we've seen is that people do a git pull and npm run global-install, and then the next time they try to git pull, they get merge conflicts with files that were updated locally by npm, and also updated and pushed to the repo by someone else. So given the way we're having normal non-developer users use npm commands to install dev versions of oref0, I'd rather not have any files present that are automatically updated by npm on the rigs of non-developers.

removed npm-shrinkwrap.json. The proper way is not using npm run global-install and using a published npm package, but that's quite some work to migrate to that.

I had problems with bluez 5.50. Will need to investigate later. Use known good version for now.

reapply of 5dfbf98

see discussion with Scoot https://gitter.im/openaps/oref0?at=5b846a0f4be56c5918a47709

…install a fresh one use 5.48.

scottleibrand · 2018-08-28T14:24:32Z

bin/openaps-packages.sh

 #if ! sudo apt-get install -y npm; then
 # install/upgrade to node 8
-if ! nodejs --version | grep 'v8.'; then
+if ! nodejs --version | grep 'v8.11'; then


Won’t this break when 8.12 comes out?

yes, changed to

# install/upgrade to latest node 8 if neither node 8 nor node 10+ LTS are installed if ! nodejs --version | grep -e 'v8\.' -e 'v1[02468]\.' ; then

…grade Resolved Conflicts: # bin/oref0-pump-loop.sh # bin/oref0-setup.sh

…nto 201808_upgrade # Conflicts: # bin/oref0-setup.sh

…14/16/18 is not available

…d code

…ring `git stash`

…grade

…in preferences.json, fix bug in .cgm_loop_path for CGM=g4-go, upgrade golang - improved the text for the Go libs, making it more clear that D will use a released version, and otherwise you need a tags - (temporary) remove .nightscout_api_secret because it's unhashed and because it's not yet used, see discussion https://gitter.im/openaps/oref0?at=5ba653d6f7e15806250b8c7b - fix bug that cgm_loop_path was wrong for g4-go - upgrade golang from 1.9 to 1.11

scottleibrand · 2018-10-07T23:03:30Z

Fixed merge conflicts and made a few other small changes in https://github.com/openaps/oref0/compare/dev...PieterGit-201808_upgrade?expand=1 to get it to the point where I think it's ready to merge. @PieterGit is this/that ready to merge from your perspective?

scottleibrand · 2018-10-07T23:06:45Z

Testing that, I get:

npm ERR! missing: request@^2.79.0, required by [email protected]
npm ERR! missing: share2nightscout-bridge@git://github.com/nightscout/share2nightscout-bridge.git#wip/generalize, required by [email protected]
npm ERR! missing: yargs@^12.0.1, required by [email protected]
npm ERR! error in /usr/lib/node_modules/oref0/node_modules/wrap-ansi: ENOENT: no such file or directory, open '/root/src/oref0/node_modules/wrap-ansi/package.json'

npm ERR! invalid: [email protected] /usr/lib/node_modules/oref0/node_modules/share2nightscout-bridge
npm ERR! invalid: [email protected] /usr/lib/node_modules/oref0/node_modules/yargs

Investigating...

scottleibrand · 2018-10-07T23:17:27Z

The first time I ran oref0-runagain, it errored out completely, complaining about missing packages and files. Re-running it, it still got a bunch of complaints about share2nightscout-bridge and yargs, but it continued past them successfully. On the third run, it didn't complain at all. Not sure if there's some order-of-operations bug here or what: we'll have to keep an eye on what happens on additional rigs.

scottleibrand · 2018-10-08T00:50:27Z

Looks like the latest yargs is incompatible with node 0.10:

/root/src/oref0/node_modules/yargs/index.js:5
const yargs = require('./yargs')
^^^^^
SyntaxError: Use of const in strict mode.
at Module._compile (module.js:439:25)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at Object. (/root/src/oref0/bin/oref0-get-profile.js:42:16)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
Could not run oref0-get-profile

So I just updated #1136 to force upgrade to node 8+

scottleibrand · 2018-10-08T02:35:12Z

Closing in favor of #1136

PieterGit and others added 12 commits August 18, 2018 14:26

update share2nightscout-bridge to version Nightscout 0.10.3 uses and …

7618e58

…add npm shrinkwrap

bluez fixes

3845e86

- upgrade bluez to 5.50 (if < 5.43 is available) - remove spaces at the end of lines - auto install bluez-tools (add -y flag)

fixes to oref0-setup.sh for WW pump

57ed61b

- show latests versions of ecc1 libraries as example - remove duplicate buildgofromsource line - fix .profile warning - use Mhz notation for medtronic_frequency.ini

Merge branch 'dev' of https://github.com/openaps/oref0 into 201808_up…

839a940

…grade

remove oref0-dexusb-cgm-loop.py from 0.7.0

c502ec9

you should instead use G4-Go which is much better alternative

remove oref0-dexusb-cgm-loop

cfc8774

use G4-Go instead

see if we can do without rebooting for radio errors with the Go libs

3fde077

fixes to oref0-setup.sh

cb430dc

only ask for ww_ti_usb_edison on non edison hardware append radio_locale to pump.ini

fix bluetooth replace script part

e0b2d7f

the other find gave an empty set on edison

Removed unused oref0-dexusb-cgm-loop script.

1301630

cherrypicks

ed64d0a

Set pump id and debug state in oref0-radio-tune.

49eea3b

Jeremy Cunningham and others added 6 commits August 20, 2018 09:19

Changed name of oref0-radio-tune.sh to oref0-mmtune.sh

8b923df

Initialize MEDTRONIC_FREQUENCY and assert current working directory i…

26ed759

…s openaps environment.

Moved residual oref0-mmtune lines from oref0-pump-loop to oref0-mmtune.

5378485

Added echo for new line.

8ce1343

small improvements to autotune

68243c5

- the autotune did not list the time of execution. added - autotune requires en_US.UTF-8 locale. This is not installed on a fresh edison. Install it if autotune is enabled.

Merge branch 'dev' of https://github.com/openaps/oref0 into 201808_up…

3bb37df

…grade

scottleibrand reviewed Aug 20, 2018

View reviewed changes

PieterGit and others added 10 commits August 20, 2018 22:39

revert to bluez 5.43.

f70533d

I had problems with bluez 5.50. Will need to investigate later. Use known good version for now.

add hours on Leaving insulinEndTime unchanged message

87d56be

Added check for file size of pump read results.

fd988a9

Use grep to determine if contents are valid.

f6b7905

Merge branch 'dev' into 201808_upgrade

739d9e5

add timeout to fix pip/pip3 install problems

af767f4

reapply of 5dfbf98

npm 6 sorts dependencies

9cbfde2

drop npm pins for yargs and json packages

ba0470d

see discussion with Scoot https://gitter.im/openaps/oref0?at=5b846a0f4be56c5918a47709

install node 8.11.4 and require node 8.11.x

3d55d3d

fix messup in version numbers. min bluetooth version is 5.43, if you …

fc74df3

…install a fresh one use 5.48.

PieterGit changed the title ~~various fixes (mainly WW related) from fresh edison install~~ various fixes (mainly WW related) from fresh edison/rpi0 install Aug 27, 2018

scottleibrand reviewed Aug 28, 2018

View reviewed changes

PieterGit and others added 13 commits September 8, 2018 15:32

Merge branch 'dev' of https://github.com/openaps/oref0 into 201808_up…

6ec676f

…grade Resolved Conflicts: # bin/oref0-pump-loop.sh # bin/oref0-setup.sh

Merge branch '201808_upgrade' of https://github.com/PieterGit/oref0 i…

b125392

…nto 201808_upgrade # Conflicts: # bin/oref0-setup.sh

install latest node 8 with Node installation if node 8 or node 10/12/…

02a0777

…14/16/18 is not available

don't install nodejs-legacy and then install nodejs 8 LTS, remove dea…

37d27eb

…d code

remove npm-shrinkwrap to prevent problems with updating rig and requi…

9d05663

…ring `git stash`

also generate radio_locale (required for WW pumps)

84845f5

add more info on what to do if you use CGM=g4-upload

71c4b7e

don't fail install if /usr/local/bin/mmtune does not exist

cd15f9a

add loging and fix last Go-mmtune move

74759d4

use oref0-setup.sh from the github to make sure your using the latest

8577fa1

Merge branch 'dev' of https://github.com/openaps/oref0 into 201808_up…

ab094fd

…grade

Merge branch 'dev' of https://github.com/openaps/oref0 into 201808_up…

3bdf470

…grade

scottleibrand mentioned this pull request Oct 8, 2018

various fixes #1136

Merged

scottleibrand closed this Oct 8, 2018

PieterGit deleted the 201808_upgrade branch December 25, 2018 08:37

various fixes (mainly WW related) from fresh edison/rpi0 install #1087

various fixes (mainly WW related) from fresh edison/rpi0 install #1087

Uh oh!

Conversation

PieterGit commented Aug 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jpcunningh commented Aug 19, 2018

Uh oh!

scottleibrand left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PieterGit Sep 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PieterGit Aug 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

scottleibrand commented Oct 7, 2018

Uh oh!

scottleibrand commented Oct 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

scottleibrand commented Oct 7, 2018

Uh oh!

scottleibrand commented Oct 8, 2018

Uh oh!

scottleibrand commented Oct 8, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PieterGit commented Aug 19, 2018 •

edited

Loading

PieterGit Sep 10, 2018 •

edited

Loading

PieterGit Aug 20, 2018 •

edited

Loading

scottleibrand commented Oct 7, 2018 •

edited

Loading