per #1401 ensure that halfBasalTarget is >=130 #1402
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My autotune_max is 1.2 My ISF is 2.0. The minimum ISF is 2.0 / 1.2 = 1.7. The difference from the minimum ISF and default ISF is 0.3 for me. |
Contributor
Author
|
Merged #1403 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1401 a halfBasalTarget of 120 causes a divide by zero, and halfBasalTarget <120 causes negative sensitivityRatio. Anything 121-129 would IMO cause the system to behave way too strongly to very slight changes in temp target, so I propose we hard-code the minimum halfBasalTarget to 130 mg/dL.