per #1401 set highest sensitivity on low TT and halfBasal #1403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getting multiplication less or equal to 0 means that we have a really low target with a really low halfBasalTarget with low TT and lowTTlowersSensitivity we need autosens_max as a value we use multiplication instead of the division to avoid "division by zero error"
|
@scottleibrand, I think that is the best solution of #1401 bug. |
scottleibrand
approved these changes
Jul 16, 2021
Contributor
scottleibrand
left a comment
scottleibrand
left a comment
There was a problem hiding this comment.
Code LGTM. If someone can give it a test on a rig and paste the output, this should be good to merge to dev.
|
@scottleibrand, I want test that code and removed the file determine-basal.js from src/oref0/lib/determine-basal/ directory and rebooted the Intel Edison. But OpenAps continues to work. Why? |
Contributor
|
Generally, this would indicate that you were using a packaged install, rather than an install linked to the source code in src/. |
Contributor
|
Tested this on a rig, and it doesn't affect sensitivityRatio during normal operation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as described in #1401 we have a possibility of zero or negative ratio on low TT and halfBasalTarget.
This ensures that we don't get over the autosens_max even in these situations
getting multiplication less or equal to 0 means that we have a really low target with a really low halfBasalTarget
with low TT and lowTTlowersSensitivity we need autosens_max as a value
we use multiplication instead of the division to avoid "division by zero error"