WIP: Relates to #81. Update to Electron v4.1.0 #91

ltfschoen · 2019-01-10T21:32:07Z

Incorporates review comments from the PR for Electron v3.1.0 WIP: Relates to #81. Update to Electron v3.1.0 #90
fether terminal tab
- check that version numbers imported into Fether packages (i.e. "@parity/electron": "^3.0.1",)
  match the version number in each js-lib package's package.json version number
- Note: use 3.0.1 until this issue is resolved Figure out why @parity/electron is not bumped up and published to npm #58

nvm use 10.11.0;
cd ~/code/src/paritytech/fether;
git checkout luke-309-electron-4;
yarn; yarn build;

js-libs terminal tab

nvm use 10.11.0;
cd ~/code/src/paritytech/js-libs;
git checkout luke-81-electron-4;
yarn build;
cp -r packages/electron/lib ../fether/node_modules/@parity/electron/lib;

fether terminal tab

yarn start

…ctron 4 * Add contributor instructions for forking, cloning, testing, linting, and building * Add contributor instructions for checking if dependencies need updating * Add contributor instructions for updating dependencies and checking that latest library updates integrate with other repos by adding a version number to the package.json so that it may be installed from a remote branch. * Add minimum Node.js version compatible with Electron 4.

…tsc when install as dependency

…inary error when install as dependency

* Update to Electron v3.1.0 - https://github.com/electron/electron/releases * Update Readme * Update dependencies versions * Add .nvmrc

Otherwise when try to use the package from a remote branch such as ``` "@parity/electron": "https://github.com/paritytech/js-libs.git#luke-81-electron-3", ``` Then it produces error: ``` error Can't add "@parity/electron": invalid package version undefined. ```

When I add this to the fether-electron package.json dependency with: ``` "@parity/electron": "https://github.com/paritytech/js-libs.git#luke-81-electron-3", ``` And then try to run `yarn; yarn build;`, it gives the following error: ``` scon @ ~/code/src/paritytech/fether - [luke-309-electron-3] $ yarn; yarn build yarn install v1.12.3 [1/5] 🔍 Validating package.json... [2/5] 🔍 Resolving packages... [3/5] 🚚 Fetching packages... [4/5] 🔗 Linking dependencies... warning " > [email protected]" has unmet peer dependency "eslint@>= 4.12.1". warning " > [email protected]" has unmet peer dependency "prop-types@^15.6.1". warning " > [email protected]" has unmet peer dependency "react@^16.4.0". warning "workspace-aggregator-cc67e372-3487-4efc-8fcb-a403fb15962c > fether-react > @parity/[email protected]" has incorrect peer dependency "rxjs@~6.2.2". warning "workspace-aggregator-cc67e372-3487-4efc-8fcb-a403fb15962c > fether-react > @parity/[email protected]" has incorrect peer dependency "rxjs@~6.2.2". warning "workspace-aggregator-cc67e372-3487-4efc-8fcb-a403fb15962c > fether-react > [email protected]" has unmet peer dependency "prop-types@^15.6.0". warning "workspace-aggregator-cc67e372-3487-4efc-8fcb-a403fb15962c > fether-react > [email protected]" has unmet peer dependency "prop-types@^15.6.0". warning "workspace-aggregator-cc67e372-3487-4efc-8fcb-a403fb15962c > fether-react > @babel/[email protected]" has unmet peer dependency "@babel/core@^7.0.0-0". warning "workspace-aggregator-cc67e372-3487-4efc-8fcb-a403fb15962c > fether-ui > [email protected]" has unmet peer dependency "react-dom@>=0.14.0 <= 16". warning "workspace-aggregator-cc67e372-3487-4efc-8fcb-a403fb15962c > fether-react > @babel/plugin-proposal-decorators > @babel/[email protected]" has unmet peer dependency "@babel/core@^7.0.0-0". [5/5] 📃 Building fresh packages... [1/2] ⠄ @parity/electron error /Users/scon/code/src/paritytech/fether/node_modules/@parity/electron: Command failed. Exit code: 1 Command: yarn build Arguments: Directory: /Users/scon/code/src/paritytech/fether/node_modules/@parity/electron Output: yarn run v1.12.3 $ lerna exec yarn build --stream lerna notice cli v3.10.1 lerna info Executing command in 6 packages: "yarn build" @parity/abi: $ rimraf lib @parity/electron: $ rimraf lib @parity/abi: $ tsc @parity/abi: /bin/sh: tsc: command not found @parity/electron: $ tsc @parity/abi: error Command failed with exit code 127. @parity/abi: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. @parity/electron: /bin/sh: tsc: command not found lerna ERR! yarn build exited 1 in '@parity/abi' lerna WARN complete Waiting for 1 child process to exit. CTRL-C to exit immediately. error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. ```

amaury1093 · 2019-01-11T14:34:50Z

@ltfschoen Can I close #90?

ltfschoen · 2019-01-13T03:04:09Z

@ltfschoen Can I close #90?

Yes I've closed it now

ltfschoen · 2019-01-13T03:07:27Z

@amaurymartiny I wonder why the CI is failing with error Couldn't find any versions for "electron" that matches "^2.0.2 | ^3.1.0 | ^4.0.1"

…updates

ltfschoen · 2019-01-13T13:10:02Z

@amaurymartiny I don't think I can progress this PR without first resolving #58.
I've looked at the code to try and resolve #58 but I didn't see what could be wrong, so I was thinking the next step would be to fork js-libs, and to sign up to NPM and trying to deploy it myself to see if there are any logs that identify the issue. What do you think

amaury1093

Looks good, except for the CI error.

I can manually update packages to npm, I didn't do it until now because the electron package didn't change. But I will bump the version on npm once this is merged.

So #58 is not a blocker, just a small (and quite weird) annoyance.

amaury1093 · 2019-01-13T23:22:59Z

packages/electron/package.json

    "@types/async-retry": "^1.2.1",
    "@types/checksum": "^0.1.30",
-    "electron": "^2.0.2"
+    "electron": "^2.0.2 | ^3.1.0 | ^4.0.1",


^4.0.1 here.

Solves:

I wonder why the CI is failing with error Couldn't find any versions for "electron" that matches "^2.0.2 | ^3.1.0 | ^4.0.1"

…n version Tries to solve the following error when push to Github and CI runs ``` CI is failing with error Couldn't find any versions for "electron" that matches "^2.0.2 | ^3.1.0 | ^4.0.1" ```

ltfschoen · 2019-01-14T01:54:44Z

@amaurymartiny It appears to be passing CI now since applying the changes to suggested, except for coveralls

amaury1093 · 2019-01-14T09:03:43Z

package.json

 {
  "name": "js-libs",
  "description": "A collection of JavaScript libraries for dapp development.",
+  "version": "v3.0.26",


Remove this.

I just tried a lerna version patch --push false locally, it bumps all packages correctly, but doesn't bump this. I'm pretty sure lerna doesn't need a version here.

amaury1093 · 2019-01-14T09:04:23Z

No problem for coveralls

amaury1093 · 2019-01-14T12:09:27Z

packages/contracts/package.json

    "docs": "typedoc && rimraf docs/README.md",
    "prebuild": "rimraf lib",
-    "build": "tsc",
+    "build": "yarn && ./node_modules/.bin/tsc",


Sorry for the late comment, but i just (re-)saw this. With the new step 7 in the readme, tsc command is enough.

amaury1093

Thanks Luke!

ltfschoen added 13 commits December 27, 2018 05:52

fix: Fixes #81. Update to Electron 4

08790aa

docs: Use NPM outdated

47a48da

fix: Add typescript to devDependencies of abi package to fix missing …

6f2f89a

…tsc when install as dependency

fix: Add Typescript dependency to all packages to avoid missing tsc b…

cd69d03

…inary error when install as dependency

fix: Use tsc binary of package not global version

146fc60

fix: Install dependencies first before run tsc

b7a049f

fix: Install dependencies before run tsc

955fbad

Able to run yarn and yarn build using Node.js v10.11.0

1bf180e

feat: Relates to #81. Update to Electron v3.1.0

1bd8d8f

* Update to Electron v3.1.0 - https://github.com/electron/electron/releases * Update Readme * Update dependencies versions * Add .nvmrc

review-fix: Updates to address comments in the electron 3 PR

2d55506

fix: Remove useless .nvmrc file

06ce040

ltfschoen mentioned this pull request Jan 13, 2019

WIP: Relates to #81. Update to Electron v3.1.0 #90

Closed

ltfschoen added 2 commits January 13, 2019 13:56

review-fix: Update Readme Step 7

17a89b9

review-fix: Revert back to just tsc command since resolved Step 7 issue

8e9ce07

review-fix: Remove version number from main package.json. See Readme …

7f2ca26

…updates

ltfschoen added the question Further information is requested label Jan 13, 2019

ltfschoen mentioned this pull request Jan 13, 2019

Figure out why @parity/electron is not bumped up and published to npm #58

Closed

amaury1093 reviewed Jan 13, 2019

View reviewed changes

ltfschoen added 4 commits January 14, 2019 12:26

fix: Remove .npmrc file

39c0d46

merge latest from master

1f30339

remove .nvmrc

044b089

review-fix: Fix to resolve CI failing as cannot find matching electro…

f0f620a

…n version Tries to solve the following error when push to Github and CI runs ``` CI is failing with error Couldn't find any versions for "electron" that matches "^2.0.2 | ^3.1.0 | ^4.0.1" ```

ltfschoen removed the question Further information is requested label Jan 14, 2019

ltfschoen added the please review label Jan 14, 2019

amaury1093 reviewed Jan 14, 2019

View reviewed changes

review-fix: Remove version number

b4df637

amaury1093 reviewed Jan 14, 2019

View reviewed changes

review-fix: Revert to just tsc in package.json build

f8717f7

amaury1093 approved these changes Jan 14, 2019

View reviewed changes

amaury1093 merged commit fd69e11 into master Jan 14, 2019

amaury1093 deleted the luke-81-electron-4 branch January 14, 2019 12:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

WIP: Relates to #81. Update to Electron v4.1.0 #91

WIP: Relates to #81. Update to Electron v4.1.0 #91

Uh oh!

ltfschoen commented Jan 10, 2019 •

edited

Loading

Uh oh!

amaury1093 commented Jan 11, 2019

Uh oh!

ltfschoen commented Jan 13, 2019

Uh oh!

ltfschoen commented Jan 13, 2019

Uh oh!

ltfschoen commented Jan 13, 2019

Uh oh!

amaury1093 left a comment

Uh oh!

amaury1093 Jan 13, 2019

Uh oh!

ltfschoen commented Jan 14, 2019

Uh oh!

amaury1093 Jan 14, 2019 •

edited

Loading

Uh oh!

amaury1093 commented Jan 14, 2019

Uh oh!

amaury1093 Jan 14, 2019

Uh oh!

amaury1093 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

WIP: Relates to #81. Update to Electron v4.1.0 #91

WIP: Relates to #81. Update to Electron v4.1.0 #91

Uh oh!

Conversation

ltfschoen commented Jan 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amaury1093 commented Jan 11, 2019

Uh oh!

ltfschoen commented Jan 13, 2019

Uh oh!

ltfschoen commented Jan 13, 2019

Uh oh!

ltfschoen commented Jan 13, 2019

Uh oh!

amaury1093 left a comment

Choose a reason for hiding this comment

Uh oh!

amaury1093 Jan 13, 2019

Choose a reason for hiding this comment

Uh oh!

ltfschoen commented Jan 14, 2019

Uh oh!

amaury1093 Jan 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amaury1093 commented Jan 14, 2019

Uh oh!

amaury1093 Jan 14, 2019

Choose a reason for hiding this comment

Uh oh!

amaury1093 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ltfschoen commented Jan 10, 2019 •

edited

Loading

amaury1093 Jan 14, 2019 •

edited

Loading