Skip to content
This repository was archived by the owner on May 24, 2022. It is now read-only.

WIP: Relates to #81. Update to Electron v4.1.0 #91

Merged
amaury1093 merged 23 commits into from
Jan 14, 2019
Merged

WIP: Relates to #81. Update to Electron v4.1.0 #91

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
08790aa
fix: Fixes #81. Update to Electron 4
ltfschoen Dec 26, 2018
2c23b75
misc: Contributor instructions. Minimum Node.js version check for Ele…
ltfschoen Dec 26, 2018
47a48da
docs: Use NPM outdated
ltfschoen Dec 26, 2018
6f2f89a
fix: Add typescript to devDependencies of abi package to fix missing …
ltfschoen Dec 26, 2018
cd69d03
fix: Add Typescript dependency to all packages to avoid missing tsc b…
ltfschoen Dec 26, 2018
146fc60
fix: Use tsc binary of package not global version
ltfschoen Dec 26, 2018
b7a049f
fix: Install dependencies first before run tsc
ltfschoen Dec 26, 2018
955fbad
fix: Install dependencies before run tsc
ltfschoen Dec 26, 2018
1bf180e
Able to run yarn and yarn build using Node.js v10.11.0
ltfschoen Dec 27, 2018
1bd8d8f
feat: Relates to #81. Update to Electron v3.1.0
ltfschoen Jan 9, 2019
8b347e0
fix: Add version to NPM package.json
ltfschoen Jan 9, 2019
73c2042
fix: Update dependencies. See commit details
ltfschoen Jan 9, 2019
2d55506
review-fix: Updates to address comments in the electron 3 PR
ltfschoen Jan 10, 2019
06ce040
fix: Remove useless .nvmrc file
ltfschoen Jan 13, 2019
17a89b9
review-fix: Update Readme Step 7
ltfschoen Jan 13, 2019
8e9ce07
review-fix: Revert back to just tsc command since resolved Step 7 issue
ltfschoen Jan 13, 2019
7f2ca26
review-fix: Remove version number from main package.json. See Readme …
ltfschoen Jan 13, 2019
39c0d46
fix: Remove .npmrc file
ltfschoen Jan 14, 2019
1f30339
merge latest from master
ltfschoen Jan 14, 2019
044b089
remove .nvmrc
ltfschoen Jan 14, 2019
f0f620a
review-fix: Fix to resolve CI failing as cannot find matching electro…
ltfschoen Jan 14, 2019
b4df637
review-fix: Remove version number
ltfschoen Jan 14, 2019
f8717f7
review-fix: Revert to just tsc in package.json build
ltfschoen Jan 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Add version to NPM package.json 
Otherwise when try to use the package from a remote branch such as
```
"@parity/electron": "https://github.com/paritytech/js-libs.git#luke-81-electron-3",
```
Then it produces error:
```
error Can't add "@parity/electron": invalid package version undefined.
```
  • Loading branch information
@ltfschoen
ltfschoen committed Jan 9, 2019
commit 8b347e047c260e53f3da0955bf87bb2c10de2744
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "js-libs",
"description": "A collection of JavaScript libraries for dapp development.",
"version": "v3.0.26",
Copy link
Collaborator

@amaury1093 amaury1093 Jan 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this.

I just tried a lerna version patch --push false locally, it bumps all packages correctly, but doesn't bump this. I'm pretty sure lerna doesn't need a version here.

"author": "Parity Team <[email protected]>",
"maintainers": [
"Amaury Martiny"
Expand Down