8373374: [lworld] Remove Unsafe.get/putValue

[liach]

Remove the old Unsafe getValue and putValue, which had some performance difficulties because they are megamorphic depending on the exact layout.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8373374: [lworld] Remove Unsafe.get/putValue (Enhancement - P4)

Reviewers

• Tobias Hartmann (@TobiHartmann - Committer)
• Jatin Bhateja (@jatin-bhateja - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1782/head:pull/1782
$ git checkout pull/1782

Update a local copy of the PR:
$ git checkout pull/1782
$ git pull https://git.openjdk.org/valhalla.git pull/1782/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1782

View PR using the GUI difftool:
$ git pr show -t 1782

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1782.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373374: [lworld] Remove Unsafe.get/putValue

Reviewed-by: thartmann, jbhateja

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the lworld branch:

• c670652: 8373506: [lworld] Disable currently unsupported builds in GHA
• cf0c0c0: 8373442: [lworld] Fix CDS heap dumping crashes
• 40958cc: 8373284: [lworld] More tests could be rewritten with LayoutKindHelper

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[jatin-bhateja]

Removed my comments unrelated to this PR and moved them to following merge PR which has been updated with latest code from lworld
#1688

I plan to conclude this merge by next week, there are some failures, if the code changes are too many then I will open seperate follow up PRs for them instead of adding them with merge.

We don't use Unsafe.putValue/getValue in VectorAPI fallback so removing them looks fine to me.

Best Regards

[mlbridge]

Webrevs

• 01: Full - Incremental (860e902f)
• 00: Full (708675bc)

[TobiHartmann]

C2 changes look good to me. Thanks!

[liach]

Tier 1-3 looks clear. Thanks for the reviews.

/integrate

[openjdk]

Going to push as commit 2f2fd63.
Since your change was applied there have been 3 commits pushed to the lworld branch:

• c670652: 8373506: [lworld] Disable currently unsupported builds in GHA
• cf0c0c0: 8373442: [lworld] Fix CDS heap dumping crashes
• 40958cc: 8373284: [lworld] More tests could be rewritten with LayoutKindHelper

Your commit was automatically rebased without conflicts.

[openjdk]

@liach Pushed as commit 2f2fd63.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.