Skip to content

Conversation

@Isabirye1515
Copy link
Contributor

@Isabirye1515 Isabirye1515 commented Jun 20, 2025

…ions

Description of what I changed

Issue I worked on

see https://openmrs.atlassian.net/browse/TRUNK-5804

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@Isabirye1515
Copy link
Contributor Author

@mherman22 , i request review

@Isabirye1515 Isabirye1515 requested a review from mherman22 July 10, 2025 15:56
@dkayiwa
Copy link
Member

dkayiwa commented Aug 27, 2025

@Isabirye1515 are you still working on this?

@Isabirye1515
Copy link
Contributor Author

@dkayiwa , how is this update

@Audited
@Entity
@Table(name = "form")
@AttributeOverride(name = "retireReason", column = @Column(name = "retired_reason", length = 255))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you overriding the retireReason attribute?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Isabirye1515 do you have a response to the above?

@Isabirye1515
Copy link
Contributor Author

Isabirye1515 commented Sep 11, 2025

@dkayiwa ,i get this, there was a typo,
Screenshot from 2025-09-11 14-54-34

@dkayiwa
Copy link
Member

dkayiwa commented Sep 11, 2025

The error that you are getting is caused by the field named retired_reason yet the base class has retire_reason

@Isabirye1515
Copy link
Contributor Author

Isabirye1515 commented Sep 12, 2025

Screenshot from 2025-09-12 03-33-16 @dkayiwa , i dint want to go updating all the liquibase snapshots, should i do that, this when i update this baseOpenmrsMetaData property @column(name = "retired_reason", length = 255) private String retireReason;

@Isabirye1515
Copy link
Contributor Author

@dkayiwa , i think you wanted this , what should be removed then

@Isabirye1515
Copy link
Contributor Author

Screenshot from 2025-09-12 07-51-28

@Isabirye1515
Copy link
Contributor Author

@dkayiwa , what should i do next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants