-
Notifications
You must be signed in to change notification settings - Fork 4.1k
TRUNK-5804:Form Domain - Switching from Hibernate Mappings to Annotational #5084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@mherman22 , i request review |
|
@Isabirye1515 are you still working on this? |
|
@dkayiwa , how is this update |
| @Audited | ||
| @Entity | ||
| @Table(name = "form") | ||
| @AttributeOverride(name = "retireReason", column = @Column(name = "retired_reason", length = 255)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you overriding the retireReason attribute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Isabirye1515 do you have a response to the above?
|
@dkayiwa ,i get this, there was a typo, |
|
The error that you are getting is caused by the field named |
|
@dkayiwa , i think you wanted this , what should be removed then |
967eea1 to
9b8eecc
Compare
9b8eecc to
4e91552
Compare
4e91552 to
f21723b
Compare
|
@dkayiwa , what should i do next |



…ions
Description of what I changed
Issue I worked on
see https://openmrs.atlassian.net/browse/TRUNK-5804
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master