Skip to content
Open
Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions api/src/main/java/org/openmrs/Form.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,28 +16,53 @@
import java.util.List;
import java.util.Set;

import jakarta.persistence.AttributeOverride;
import jakarta.persistence.CascadeType;
import jakarta.persistence.Column;
import jakarta.persistence.Entity;
import jakarta.persistence.FetchType;
import jakarta.persistence.GeneratedValue;
import jakarta.persistence.GenerationType;
import jakarta.persistence.Id;
import jakarta.persistence.JoinColumn;
import jakarta.persistence.ManyToOne;
import jakarta.persistence.OneToMany;
import jakarta.persistence.Table;

/**
* Form
*
* @version 1.0
*/
@Audited
@Entity
@Table(name = "form")
@AttributeOverride(name = "retireReason", column = @Column(name = "retired_reason", length = 255))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you overriding the retireReason attribute?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Isabirye1515 do you have a response to the above?

@AttributeOverride(name="description", column = @Column(name = "description", length = 1024))
public class Form extends BaseChangeableOpenmrsMetadata {

public static final long serialVersionUID = 845634L;

// Fields

@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
@Column(name = "form_id")
private Integer formId;


@Column(name = "version", nullable = false, length = 50)
private String version;

@Column(name = "build", nullable = true)
private Integer build;

@Column(name = "published", length = 1)
private Boolean published = false;


@ManyToOne
@JoinColumn(name = "encounter_type")
private EncounterType encounterType;


@OneToMany(mappedBy = "form", cascade = CascadeType.ALL, orphanRemoval = true, fetch = FetchType.LAZY)
private Set<FormField> formFields;

// Constructors
Expand Down Expand Up @@ -231,4 +256,4 @@ public void setId(Integer id) {
setFormId(id);

}
}
}
1 change: 0 additions & 1 deletion api/src/main/resources/hibernate.cfg.xml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
<mapping resource="org/openmrs/api/db/hibernate/DiagnosisAttributeType.hbm.xml" />
<mapping resource="org/openmrs/api/db/hibernate/Field.hbm.xml" />
<mapping resource="org/openmrs/api/db/hibernate/FieldType.hbm.xml" />
<mapping resource="org/openmrs/api/db/hibernate/Form.hbm.xml" />
<mapping resource="org/openmrs/api/db/hibernate/FormField.hbm.xml" />
<mapping resource="org/openmrs/api/db/hibernate/GlobalProperty.hbm.xml" />
<mapping resource="org/openmrs/api/db/hibernate/Obs.hbm.xml" />
Expand Down
83 changes: 0 additions & 83 deletions api/src/main/resources/org/openmrs/api/db/hibernate/Form.hbm.xml

This file was deleted.

2 changes: 2 additions & 0 deletions api/src/test/java/org/openmrs/api/OrderServiceTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
import org.openmrs.DrugOrder;
import org.openmrs.Encounter;
import org.openmrs.EncounterRole;
import org.openmrs.Form;
import org.openmrs.FreeTextDosingInstructions;
import org.openmrs.GlobalProperty;
import org.openmrs.Location;
Expand Down Expand Up @@ -2787,6 +2788,7 @@ public void saveOrder_shouldFailIfTheJavaTypeOfThePreviousOrderDoesNotMatch() th
.addAnnotatedClass(ConceptNameTag.class)
.addAnnotatedClass(CareSetting.class)
.addAnnotatedClass(LocationTag.class)
.addAnnotatedClass(Form.class)
.getMetadataBuilder().build();


Expand Down
Loading