Updates Proxy TrustedCA godocs #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, danehans The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
abhinavdahiya
added a commit
to abhinavdahiya/installer
that referenced
this pull request
Aug 7, 2019
abhinavdahiya
added a commit
to abhinavdahiya/installer
that referenced
this pull request
Aug 7, 2019
…shift-config based on openshift/api#400 the location of the config map should be openshift-config namespace
abhinavdahiya
added a commit
to abhinavdahiya/cluster-version-operator
that referenced
this pull request
Aug 7, 2019
follow up from openshift/api#400
jhixson74
pushed a commit
to jhixson74/installer
that referenced
this pull request
Dec 6, 2019
jhixson74
pushed a commit
to jhixson74/installer
that referenced
this pull request
Dec 6, 2019
…shift-config based on openshift/api#400 the location of the config map should be openshift-config namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#377 added the
trustedCAfield to the proxy api type. However, the godocs for this field referenced namespaceopenshift-config-manaedinstead ofopenshift-config. This PR fixes the godoc namespace reference.cc @abhinavdahiya @bparees @jcpowermac