Skip to content

Bug 1947797: Bump ClusterVersion and ClusterOperator CRDs to apiextensions.k8s.io/v1 #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 17, 2021
Merged

Bug 1947797: Bump ClusterVersion and ClusterOperator CRDs to apiextensions.k8s.io/v1 #921

openshift-merge-robot merged 1 commit into from
May 17, 2021

Conversation

@LalatenduMohanty
Copy link
Member

@LalatenduMohanty LalatenduMohanty commented May 7, 2021 •
edited
Loading

Modifications done as per the K8s doc https://kubernetes.io/docs/reference/using-api/deprecation-guide/

Signed-off-by: Lalatendu Mohanty [email protected]

@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label May 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 7, 2021

@LalatenduMohanty: This pull request references Bugzilla bug 1949711, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianlinliu

Details

In response to this:

Bug 1949711: Bump CRDs to apiextensions.k8s.io/v1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 7, 2021
@openshift-ci openshift-ci bot requested review from jianlinliu, mfojtik and soltysh May 7, 2021 15:10
@LalatenduMohanty
Copy link
Member Author

LalatenduMohanty commented May 7, 2021

/hold As make verify is failing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2021
@LalatenduMohanty LalatenduMohanty changed the title Bug 1949711: Bump CRDs to apiextensions.k8s.io/v1 [WIP] Bug 1949711: Bump CRDs to apiextensions.k8s.io/v1 May 7, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2021
@wking
Copy link
Member

wking commented May 7, 2021

/retitle [WIP] Bug 1947797: Bump ClusterVersion and ClusterOperator CRDs to apiextensions.k8s.io/v1

@openshift-ci openshift-ci bot changed the title [WIP] Bug 1949711: Bump CRDs to apiextensions.k8s.io/v1 [WIP] Bug 1947797: Bump ClusterVersion and ClusterOperator CRDs to apiextensions.k8s.io/v1 May 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 7, 2021

@LalatenduMohanty: This pull request references Bugzilla bug 1947797, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

[WIP] Bug 1947797: Bump ClusterVersion and ClusterOperator CRDs to apiextensions.k8s.io/v1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LalatenduMohanty LalatenduMohanty force-pushed the bz_1947797 branch 2 times, most recently from 2832e22 to 4f0cbe4 Compare May 13, 2021 20:21
@LalatenduMohanty LalatenduMohanty changed the title [WIP] Bug 1947797: Bump ClusterVersion and ClusterOperator CRDs to apiextensions.k8s.io/v1 Bug 1947797: Bump ClusterVersion and ClusterOperator CRDs to apiextensions.k8s.io/v1 May 13, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2021
@LalatenduMohanty
Copy link
Member Author

LalatenduMohanty commented May 13, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2021
@LalatenduMohanty
Copy link
Member Author

LalatenduMohanty commented May 13, 2021

/test verify

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2021

@LalatenduMohanty: This pull request references Bugzilla bug 1947797, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

Bug 1947797: Bump ClusterVersion and ClusterOperator CRDs to apiextensions.k8s.io/v1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2021

@LalatenduMohanty: This pull request references Bugzilla bug 1947797, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

Bug 1947797: Bump ClusterVersion and ClusterOperator CRDs to apiextensions.k8s.io/v1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LalatenduMohanty LalatenduMohanty force-pushed the bz_1947797 branch 4 times, most recently from d85152f to 0ae513e Compare May 14, 2021 19:14
@LalatenduMohanty
Copy link
Member Author

LalatenduMohanty commented May 14, 2021

/assign @sttts

@sttts
Copy link
Contributor

sttts commented May 17, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021
@openshift-merge-robot openshift-merge-robot merged commit b325f58 into openshift:master May 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2021

@LalatenduMohanty: All pull requests linked via external trackers have merged:

Bugzilla bug 1947797 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1947797: Bump ClusterVersion and ClusterOperator CRDs to apiextensions.k8s.io/v1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LalatenduMohanty LalatenduMohanty mentioned this pull request May 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jianlinliu jianlinliu Awaiting requested review from jianlinliu

@mfojtik mfojtik Awaiting requested review from mfojtik

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@sttts sttts

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LalatenduMohanty @wking @sttts @openshift-merge-robot