Bug 1947797: Bumping openshift/api to vendor apiextensions.k8s.io/v1 #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

openshift-merge-robot merged 4 commits into openshift:master from LalatenduMohanty:bumping_cvo_to_get_fix_for_bz_1947797

May 27, 2021

Member

LalatenduMohanty commented May 17, 2021

Signed-off-by: Lalatendu Mohanty [email protected]

LalatenduMohanty changed the title ~~Bumping openshift/api to get fix for bz_1947797~~ [WIP] Bumping openshift/api to get fix for bz_1947797

openshift-ci bot added the do-not-merge/work-in-progress label

openshift-ci bot requested review from abhinavdahiya and vrutkovs

May 17, 2021 20:17

openshift-ci bot added the approved label

LalatenduMohanty force-pushed the bumping_cvo_to_get_fix_for_bz_1947797 branch from ab928f0 to 9f8543a Compare

May 17, 2021 20:28

Member Author

LalatenduMohanty commented May 17, 2021 •

edited

Loading

go mod tidy is failing

$ go mod tidy
go: finding module for package k8s.io/api/discovery/v1alpha1
go: finding module for package k8s.io/api/batch/v2alpha1
github.com/openshift/cluster-version-operator/pkg/cvo imports
	k8s.io/client-go/kubernetes/scheme imports
	k8s.io/api/batch/v2alpha1: module k8s.io/api@latest found (v0.21.0), but does not contain package k8s.io/api/batch/v2alpha1
github.com/openshift/cluster-version-operator/pkg/cvo imports
	k8s.io/client-go/kubernetes/scheme imports
	k8s.io/api/discovery/v1alpha1: module k8s.io/api@latest found (v0.21.0), but does not contain package k8s.io/api/discovery/v1alpha1

Member Author

LalatenduMohanty commented May 17, 2021

/hold

openshift-ci bot added the do-not-merge/hold label

vrutkovs commented May 18, 2021

Seems that needs go mod vendor

vrutkovs commented May 18, 2021

I included the bump in #566 (its necessary there), lets close this PR?

LalatenduMohanty force-pushed the bumping_cvo_to_get_fix_for_bz_1947797 branch from 9f8543a to aead341 Compare

May 18, 2021 19:16

LalatenduMohanty changed the title ~~[WIP] Bumping openshift/api to get fix for bz_1947797~~ Bumping openshift/api to get fix for bz_1947797

openshift-ci bot removed the do-not-merge/work-in-progress label

LalatenduMohanty changed the title ~~Bumping openshift/api to get fix for bz_1947797~~ Bug 1947797: Bumping openshift/api to vendor apiextensions.k8s.io/v1

openshift-ci bot added bugzilla/severity-high bugzilla/valid-bug labels

Contributor

openshift-ci bot commented May 18, 2021

@LalatenduMohanty: This pull request references Bugzilla bug 1947797, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

Bug 1947797: Bumping openshift/api to vendor apiextensions.k8s.io/v1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Member Author

LalatenduMohanty commented May 18, 2021

I included the bump in #566 (its necessary there), lets close this PR?

The changes looks different in your PR. I wanted to get this in to CVO which has my recent changes in openshift/api#921 .

Member Author

LalatenduMohanty commented May 18, 2021

Never mind , you have the required changes in 725d4f8

Member Author

LalatenduMohanty commented May 18, 2021

/hold cancel

openshift-ci bot removed the do-not-merge/hold label

Member Author

LalatenduMohanty commented May 19, 2021

/retest

vrutkovs approved these changes

View reviewed changes

vrutkovs left a comment

/lgtm

openshift-ci bot assigned vrutkovs

openshift-ci bot added the lgtm label

Contributor

openshift-bot commented May 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments

Contributor

openshift-bot commented May 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments

Contributor

openshift-bot commented May 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

vrutkovs commented May 20, 2021 •

edited

Loading

/hold

INFO[2021-05-20T08:26:16Z] error: failed creating CRD clusterversions.config.openshift.io: CustomResourceDefinition.apiextensions.k8s.io "clusterversions.config.openshift.io" is invalid: [spec.versions: Invalid value: []apiextensions.CustomResourceDefinitionVersion{apiextensions.CustomResourceDefinitionVersion{Name:"v1", Served:true, Storage:true, Deprecated:false, DeprecationWarning:(*string)(nil), Schema:(*apiextensions.CustomResourceValidation)(0xc0484a4218), Subresources:(*apiextensions.CustomResourceSubresources)(0xc0102cd980), AdditionalPrinterColumns:[]apiextensions.CustomResourceColumnDefinition{apiextensions.CustomResourceColumnDefinition{Name:"Version", Type:"string", Format:"", Description:"", Priority:0, JSONPath:".status.history[?(@.state==\"Completed\")].version"}, apiextensions.CustomResourceColumnDefinition{Name:"Available", Type:"string", Format:"", Description:"", Priority:0, JSONPath:".status.conditions[?(@.type==\"Available\")].status"}, apiextensions.CustomResourceColumnDefinition{Name:"Progressing", Type:"string", Format:"", Description:"", Priority:0, JSONPath:".status.conditions[?(@.type==\"Progressing\")].status"}, apiextensions.CustomResourceColumnDefinition{Name:"Since", Type:"date", Format:"", Description:"", Priority:0, JSONPath:".status.conditions[?(@.type==\"Progressing\")].lastTransitionTime"}, apiextensions.CustomResourceColumnDefinition{Name:"Status", Type:"string", Format:"", Description:"", Priority:0, JSONPath:".status.conditions[?(@.type==\"Progressing\")].message"}}}}: per-version schemas may not all be set to identical values (top-level validation should be used instead), spec.versions: Invalid value: []apiextensions.CustomResourceDefinitionVersion{apiextensions.CustomResourceDefinitionVersion{Name:"v1", Served:true, Storage:true, Deprecated:false, DeprecationWarning:(*string)(nil), Schema:(*apiextensions.CustomResourceValidation)(0xc0484a4218), Subresources:(*apiextensions.CustomResourceSubresources)(0xc0102cd980), AdditionalPrinterColumns:[]apiextensions.CustomResourceColumnDefinition{apiextensions.CustomResourceColumnDefinition{Name:"Version", Type:"string", Format:"", Description:"", Priority:0, JSONPath:".status.history[?(@.state==\"Completed\")].version"}, apiextensions.CustomResourceColumnDefinition{Name:"Available", Type:"string", Format:"", Description:"", Priority:0, JSONPath:".status.conditions[?(@.type==\"Available\")].status"}, apiextensions.CustomResourceColumnDefinition{Name:"Progressing", Type:"string", Format:"", Description:"", Priority:0, JSONPath:".status.conditions[?(@.type==\"Progressing\")].status"}, apiextensions.CustomResourceColumnDefinition{Name:"Since", Type:"date", Format:"", Description:"", Priority:0, JSONPath:".status.conditions[?(@.type==\"Progressing\")].lastTransitionTime"}, apiextensions.CustomResourceColumnDefinition{Name:"Status", Type:"string", Format:"", Description:"", Priority:0, JSONPath:".status.conditions[?(@.type==\"Progressing\")].message"}}}}: per-version subresources may not all be set to identical values (top-level subresources should be used instead), spec.versions: Invalid value: []apiextensions.CustomResourceDefinitionVersion{apiextensions.CustomResourceDefinitionVersion{Name:"v1", Served:true, Storage:true, Deprecated:false, DeprecationWarning:(*string)(nil), Schema:(*apiextensions.CustomResourceValidation)(0xc0484a4218), Subresources:(*apiextensions.CustomResourceSubresources)(0xc0102cd980), AdditionalPrinterColumns:[]apiextensions.CustomResourceColumnDefinition{apiextensions.CustomResourceColumnDefinition{Name:"Version", Type:"string", Format:"", Description:"", Priority:0, JSONPath:".status.history[?(@.state==\"Completed\")].version"}, apiextensions.CustomResourceColumnDefinition{Name:"Available", Type:"string", Format:"", Description:"", Priority:0, JSONPath:".status.conditions[?(@.type==\"Available\")].status"}, apiextensions.CustomResourceColumnDefinition{Name:"Progressing", Type:"string", Format:"", Description:"", Priority:0, JSONPath:".status.conditions[?(@.type==\"Progressing\")].status"}, apiextensions.CustomResourceColumnDefinition{Name:"Since", Type:"date", Format:"", Description:"", Priority:0, JSONPath:".status.conditions[?(@.type==\"Progressing\")].lastTransitionTime"}, apiextensions.CustomResourceColumnDefinition{Name:"Status", Type:"string", Format:"", Description:"", Priority:0, JSONPath:".status.conditions[?(@.type==\"Progressing\")].message"}}}}: per-version additionalPrinterColumns may not all be set to identical values (top-level additionalPrinterColumns should be used instead)]

openshift-ci bot added the do-not-merge/hold label

Contributor

sttts commented May 25, 2021

Any progress here?

vrutkovs commented May 25, 2021

/retest

vrutkovs mentioned this pull request

WIP Bug 1947797: Bumping openshift/api to vendor apiextensions.k8s.io/v1 #574

Closed

Member Author

LalatenduMohanty commented May 25, 2021

/test e2e-agnostic-operator

Member Author

LalatenduMohanty commented May 25, 2021

Last e2e-agnostic-operator failure looks unrelated.

 ERRO[2021-05-25T19:22:02Z] Some steps failed:                           
ERRO[2021-05-25T19:22:02Z]   * could not run steps: step e2e-agnostic-operator failed: ["e2e-agnostic-operator" pre steps failed: "e2e-agnostic-operator" pod "e2e-agnostic-operator-ipi-install-install" failed: the pod ci-op-q4vcrfnh/e2e-agnostic-operator-ipi-install-install failed after 50s (failed containers: test): ContainerFailed one or more containers exited 
ERRO[2021-05-25T19:22:02Z] Container test exited with code 1, reason Error 
ERRO[2021-05-25T19:22:02Z] ---                                          
ERRO[2021-05-25T19:22:02Z] Installing from release registry.build01.ci.openshift.org/ci-op-q4vcrfnh/release@sha256:6d42d3893a4aee8f1dbe513f976b782ebc9f62225ea3871a1701612fd54b5703 
ERRO[2021-05-25T19:22:02Z] level=info msg=Credentials loaded from file "/var/run/secrets/ci.openshift.io/cluster-profile/osServicePrincipal.json" 
ERRO[2021-05-25T19:22:02Z] level=fatal msg=failed to fetch Master Machines: failed to load asset "Install Config": platform.azure.region: Internal error: failed to retrieve available regions: failed to list locations: subscriptions.Client#ListLocations: Failure sending request: StatusCode=0 -- Original Error: context deadline exceeded 
ERRO[2021-05-25T19:22:02Z] Setup phase finished, prepare env for next steps 
ERRO[2021-05-25T19:22:02Z] Copying log bundle...                        
ERRO[2021-05-25T19:22:02Z] Removing REDACTED info from log...           
ERRO[2021-05-25T19:22:02Z] Copying required artifacts to shared dir     
ERRO[2021-05-25T19:22:02Z] cp: cannot stat '/tmp/installer/auth/kubeconfig': No such file or directory 
ERRO[2021-05-25T19:22:02Z] cp: cannot stat '/tmp/installer/auth/kubeadmin-password': No such file or directory 
ERRO[2021-05-25T19:22:02Z] cp: cannot stat '/tmp/installer/metadata.json': No such file or directory 
ERRO[2021-05-25T19:22:02Z] {"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"prow/entrypoint/run.go:80","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2021-05-25T19:17:12Z"} 
ERRO[2021-05-25T19:22:02Z] error: failed to execute wrapped command: exit status 1

Member Author

LalatenduMohanty commented May 25, 2021

/test e2e-agnostic-operator

LalatenduMohanty added 2 commits

May 26, 2021 14:14


          Bug 1947797: Bumping openshift/api to vendor apiextensions.k8s.io/v1

d3fe871

Signed-off-by: Lalatendu Mohanty <[email protected]>


          Resolving dependancies with move to openshift/api/commit/b325f58df679…

b216a1b

…0afc063353aae4037e22bd98a455

        $ go mod tidy
        $ go mod vendor

Signed-off-by: Lalatendu Mohanty <[email protected]>

LalatenduMohanty force-pushed the bumping_cvo_to_get_fix_for_bz_1947797 branch from aead341 to b216a1b Compare

May 26, 2021 18:14

openshift-ci bot removed the lgtm label

Member Author

LalatenduMohanty commented May 26, 2021

/test e2e-agnostic-operator


          Bumping the k8s.io/api version to v0.21.1

f8f5fd8

Signed-off-by: Lalatendu Mohanty <[email protected]>

LalatenduMohanty force-pushed the bumping_cvo_to_get_fix_for_bz_1947797 branch from c567eb2 to f8f5fd8 Compare

May 27, 2021 14:57


          Test modification or dropping APIExtensions v1beta1

a31d8af

Copied from openshift@1421cfe

Signed-off-by: Lalatendu Mohanty <[email protected]>

wking approved these changes

View reviewed changes

Member

wking left a comment

/lgtm
/hold cancel

Neither the d3fe871 nor the f8f5fd8 commit messages explain how the changes were generated, which will make it a bit harder on whoever has to repeat this process next time. But fixing that may not be worth running a full new round of CI. The etcdHighNumberOfLeaderChanges alert is unrelated:

/override ci/prow/e2e-agnostic-upgrade

openshift-ci bot removed the do-not-merge/hold label

openshift-ci bot assigned wking

openshift-ci bot added the lgtm label

Contributor

openshift-ci bot commented May 27, 2021

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

/lgtm
/hold cancel

Neither the d3fe871 nor the f8f5fd8 commit messages explain how the changes were generated, which will make it a bit harder on whoever has to repeat this process next time. But fixing that may not be worth running a full new round of CI. The etcdHighNumberOfLeaderChanges alert is unrelated:

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

openshift-ci bot commented May 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, vrutkovs, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [LalatenduMohanty,vrutkovs,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-robot merged commit 706cca8 into openshift:master

Contributor

openshift-ci bot commented May 27, 2021

@LalatenduMohanty: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/cluster-version-operator#574 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1947797 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1947797: Bumping openshift/api to vendor apiextensions.k8s.io/v1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved bugzilla/severity-high bugzilla/valid-bug lgtm