Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Mar 12, 2020

Like 6947046 (#111), but for 4.5. There are no 4.5 consumers yet, but this change sets Cincinnati up for them once they arrive (and now that release-4.4 is no longer being fast-forwarded, the 4.5 consumers may land in the installer and console masters anytime).

Like 6947046 (channels: Add candidate-4.4, fast-4.4, and
stable-4.4, 2020-03-12, openshift#111), but for 4.5.  There are no 4.5
consumers yet, but this change sets Cincinnati up for them once they
arrive (and now that release-4.4 is no longer being fast-forwarded,
the 4.5 consumers may land in the installer and console masters
anytime).
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 12, 2020
@eparis
Copy link
Member

eparis commented Mar 12, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2020
@sdodson
Copy link
Member

sdodson commented Mar 12, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, sdodson, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4f4145d into openshift:master Mar 12, 2020
@wking wking deleted the 4.5-channels branch March 19, 2020 20:58
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Oct 2, 2020
Like adde027 (channels: Add candidate-4.5, fast-4.5, and
stable-4.5, 2020-03-12, openshift#113), but without candidate because we got
that in 713f464 (Enable 4.6.0-fc.0 in candidate channel(s),
2020-08-05, openshift#376).  This sets us up to avoid VersionNotFound issues
once [1] lands.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1884760
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Dec 3, 2020
Like adde027 (channels: Add candidate-4.5, fast-4.5, and
stable-4.5, 2020-03-12, openshift#113), but without candidate because we got
that in 713f464 (Enable 4.6.0-fc.0 in candidate channel(s),
2020-08-05, openshift#376).  This sets us up to avoid VersionNotFound issues
once [1] lands.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1884760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants