Skip to content

Bug 1813185: Add stable-4.4, fast-4.4 and candidate-4.4 channel for 4.4 release #4727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 16, 2020
Merged

Bug 1813185: Add stable-4.4, fast-4.4 and candidate-4.4 channel for 4.4 release #4727

openshift-merge-robot merged 1 commit into from
Apr 16, 2020

Conversation

@jhadvig
Copy link
Member

@jhadvig jhadvig commented Mar 13, 2020

/assign @spadgett

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 13, 2020

@jhadvig: This pull request references Bugzilla bug 1813185, which is invalid:

  • expected Bugzilla bug 1813185 to depend on a bug targeting the "4.4.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1813185: Add stable-4.4, fast-4.4 and candidate-4.4 channel for 4.4 release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 13, 2020
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Mar 13, 2020
@jhadvig
Copy link
Member Author

jhadvig commented Mar 13, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 13, 2020

@jhadvig: This pull request references Bugzilla bug 1813185, which is invalid:

  • expected Bugzilla bug 1813185 to depend on a bug targeting the "4.4.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett
spadgett approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Mar 13, 2020
@spadgett
Copy link
Member

spadgett commented Mar 13, 2020

/cc @jwforres

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett spadgett added this to the v4.3.z milestone Mar 13, 2020
@jwforres
Copy link
Member

jwforres commented Mar 13, 2020

@sdodson @LalatenduMohanty bringing in OTA folks to coordinate - this PR is what would make the 4.4 channels appear in someone's 4.3 admin console

@sdodson
Copy link
Member

sdodson commented Mar 13, 2020

Those channels were populated yesterday
openshift/cincinnati-graph-data#111
openshift/cincinnati-graph-data#114
Additionally, empty channels for 4.5 were populated as well so we could go ahead and update master too, though it's going to be a a long time before anything shows up in those channels.
openshift/cincinnati-graph-data#113

@jhadvig
Copy link
Member Author

jhadvig commented Mar 26, 2020

@spadgett @jwforres can we go ahead and merge this one ?

@wking
Copy link
Member

wking commented Apr 8, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 8, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 8, 2020

@wking: This pull request references Bugzilla bug 1813185, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1792435 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1792435 targets the "4.4.0" release, matching the expected (4.4.0) release
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member

spadgett commented Apr 8, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2020
@eparis
Copy link
Member

eparis commented Apr 16, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 16, 2020

@eparis: This pull request references Bugzilla bug 1813185, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1792435 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1792435 targets the "4.4.0" release, which is one of the valid target releases: 4.4.0, 4.4.z
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 16, 2020
@openshift-merge-robot openshift-merge-robot merged commit 2438289 into openshift:release-4.3 Apr 16, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 16, 2020

@jhadvig: All pull requests linked via external trackers have merged: openshift/console#4727. Bugzilla bug 1813185 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1813185: Add stable-4.4, fast-4.4 and candidate-4.4 channel for 4.4 release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

meysam-jeffrey pushed a commit to snapp-incubator/console that referenced this pull request Dec 24, 2025
@openshift-merge-robot
Merge pull request openshift#4727 from jhadvig/bz1813185
1f54781 
Bug 1813185: Add stable-4.4, fast-4.4 and candidate-4.4 channel for 4.4 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@kyoto kyoto Awaiting requested review from kyoto

@jwforres jwforres Awaiting requested review from jwforres

+1 more reviewer

@dtaylor113 dtaylor113 dtaylor113 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3.z

Development

Successfully merging this pull request may close these issues.

9 participants

@jhadvig @openshift-ci-robot @spadgett @jwforres @sdodson @wking @eparis @dtaylor113 @openshift-merge-robot