Add 4.2.23 to candidate

[joepvd]

No description provided.

[wking]

CI upgrades currently just 4.1.37 and 4.2.22, not all of:

$ oc adm release info quay.io/openshift-release-dev/ocp-release:4.2.23-x86_64 | grep Upgrades
  Upgrades: 4.1.31, 4.1.38, 4.2.12-s390x, 4.2.13-s390x, 4.2.14, 4.2.16, 4.2.18, 4.2.19, 4.2.20, 4.2.21, 4.2.22

I thought ART was planning on launching CI jobs for each baked-in edge (although s390x!?)? I'll launch the missing jobs now...

[wking]

Hrm, 4.1.31 is also pretty old. Are you sure we don't want to use 4.1.34 (the latest release in stable-4.1)?

[wking]

Launched tests by feeding cluster-bot:

test upgrade 4.1.31 4.2.23 aws
test upgrade 4.1.31 4.2.23 aws
test upgrade 4.1.38 4.2.23 aws
test upgrade 4.1.38 4.2.23 aws
test upgrade 4.2.14 4.2.23 gcp
test upgrade 4.2.16 4.2.23 azure,mirror
test upgrade 4.2.18 4.2.23 aws
test upgrade 4.2.19 4.2.23 gcp
test upgrade 4.2.20 4.2.23 azure,mirror
test upgrade 4.2.21 4.2.23 aws
test upgrade 4.2.22 4.2.23 gcp

Will see how those go. The four existing failures were all release-build errors for 4.2.22 -> 4.2.23 on AWS (so CI cluster/registry flakes).

[sdodson]

Hrm, 4.1.31 is also pretty old. Are you sure we don't want to use 4.1.34 (the latest release in stable-4.1)?

4.1.34 just went in yesterday, it probably wasn't in at the time the build was made.

[wking]

New CI jobs mostly passed, with only three failures:

• Azure 4.2.16 -> 4.2.23 died on install (level=fatal msg="failed to initialize the cluster: Working towards 4.2.16: 100% complete, waiting on authentication"), so not an upgrade issue. I've launched a replacement.
• GCP 4.2.22 -> 4.2.23 died with Cluster did not complete upgrade: timed out waiting for the condition: Could not update deployment "openshift-operator-lifecycle-manager/olm-operator" (323 of 432). Not sure what's going on with that; I've launched a replacement.
• AWS 4.1.38 -> 4.2.23 died on install (aws_instance.master.1: Error waiting for instance (i-08bb57ff7032ba264) to become ready: timeout while waiting for state to become 'running' (last state: 'pending', timeout: 10m0s)), no not an upgrade issue. But the other 4.1.38 -> 4.2.23 passed, so I'm not launching a replacement.

[wking]

The CI failure from the job I launched is the only such failure in at least the past 24h. And I'm personally not too worried about OLM, because it's far from the core, so I'm not going to dig further into that particular CI job.

[wking]

Would be nice to see how the two pending CI jobs work out, but I'm not too worried, and this is just a candidate promotion, so:

/lgtm

[wking]

Oh, also, I haven't looked at 4.2.23 -> 4.3.*, but the candidate-4.3 promotion here doesn't need update testing, because the latest 4.3 candidate links older 4.2 releases:

$ oc adm release info quay.io/openshift-release-dev/ocp-release:4.3.5-x86_64 | grep Upgrades
  Upgrades: 4.2.21, 4.2.22, 4.3.0, 4.3.1, 4.3.2, 4.3.3

[wking]

Would be nice to see how the two pending CI jobs work out...

And they both passed.

[eparis]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, joepvd, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• channels/OWNERS [eparis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment