Skip to content

channels: Promote 4.2.23 to fast-4.2 and fast-4.3 #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wking wants to merge 1 commit into from
Closed

channels: Promote 4.2.23 to fast-4.2 and fast-4.3 #121

wking wants to merge 1 commit into from

Conversation

@wking
Copy link
Member

@wking wking commented Mar 16, 2020

It was promoted the feeder candidate-4.2 and candidate-4.3 by dc2a3c4 (Merge pull request #115 from joepvd/candidate-4.2.23, 2020-03-13).

@wking
channels: Promote 4.2.23 to fast-4.2 and fast-4.3
372fbce 
It was promoted the feeder candidate-4.2 and candidate-4.3 by
dc2a3c4 (Merge pull request openshift#115 from joepvd/candidate-4.2.23,
2020-03-13).
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 16, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wking
To complete the pull request process, please assign jwforres
You can assign the PR to them by writing /assign @jwforres in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking wking mentioned this pull request Mar 18, 2020
Closed
@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Mar 18, 2020

There is a regression got introduced to 4.2.22 and later builds, see #125 , I would suggest that we drop this build and add the build with the fix.

@wking
Copy link
Member Author

wking commented Mar 18, 2020

/hold

We might want to tombstone this instead because of #125.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2020
@wking
Copy link
Member Author

wking commented Mar 18, 2020

I'm just going to close this. I'll file a tombstoning PR in a bit.

/close

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 18, 2020

@wking: Closed this PR.

Details

In response to this:

I'm just going to close this. I'll file a tombstoning PR in a bit.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member Author

wking commented Mar 18, 2020

Tombstoned in #127.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crawford crawford Awaiting requested review from crawford

@steveej steveej Awaiting requested review from steveej

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wking @openshift-ci-robot @LalatenduMohanty