Bug 1805987: Uses the readiness indicator file option for Multus #484

dougbtv · 2020-02-18T21:08:40Z

This helps to smooth out inconsistencies during an upgrade and helps Multus know openshift-sdn is ready.

This depends on openshift/multus-cni#47 and likely will not pass CI until that is merged.

…option This helps to smooth out inconsistencies during an upgrade and helps Multus know openshift-sdn is ready.

openshift-ci-robot · 2020-02-18T21:08:43Z

@dougbtv: This pull request references Bugzilla bug 1793635, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1793635: Uses the readiness indicator file option for Multus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-02-18T21:09:15Z

@dougbtv: This pull request references Bugzilla bug 1793635, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1793635: Uses the readiness indicator file option for Multus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

danwinship · 2020-02-19T12:42:35Z

/retitle Bug 1785457: Uses the readiness indicator file option for Multus

openshift-ci-robot · 2020-02-19T12:42:38Z

@dougbtv: This pull request references Bugzilla bug 1785457, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1785457: Uses the readiness indicator file option for Multus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

danwinship · 2020-02-19T12:43:26Z

* expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

[sad trombone noise]. 4.4 branched so now you have to fix this 3 times instead of 2

openshift-bot · 2020-02-20T16:04:54Z

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

openshift-ci-robot · 2020-02-20T16:04:57Z

@openshift-bot: This pull request references Bugzilla bug 1785457, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abhat · 2020-02-21T17:02:09Z

/lgtm

abhat · 2020-02-21T17:02:15Z

/retest

pecameron

/lgtm

danwinship · 2020-02-27T18:18:11Z

/hold

danwinship · 2020-02-27T18:19:26Z

as commented in the 4.3 bug (#485), this is openshift-sdn-specific and needs to be conditionalized

bindata/network/multus/multus.yaml

danwinship · 2020-02-27T23:41:45Z

/hold cancel

danwinship · 2020-02-28T02:23:05Z

/retest

danwinship · 2020-02-28T13:21:28Z

/retitle Bug 1805987: Uses the readiness indicator file option for Multus

openshift-ci-robot · 2020-02-28T13:21:36Z

@dougbtv: This pull request references Bugzilla bug 1805987, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1805987: Uses the readiness indicator file option for Multus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pecameron

/lgtm

pecameron · 2020-02-28T14:44:43Z

/test e2e-gcp-ovn

pecameron · 2020-02-28T15:23:32Z

Seems to be a network problem in e2e-gcp-ovn.
e2e-gcp-ovn/pods/openshift-ovn-kubernetes_ovnkube-node-kccjd_ovnkube-node.log L108, L5513
Not sure what is causing this...

juanluisvaladas · 2020-02-28T15:36:19Z

/lgtm

The multus pods seem to get ready, there are a few restarts on some pods, but they don't seem related.

curl -s https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-network-operator/484/pull-ci-openshift-cluster-network-operator-master-e2e-gcp-ovn/282/artifacts/e2e-gcp-ovn/pods.json  | prowser-get-pod  | grep multus | column -t
openshift-multus  multus-admission-controller-lqst5  1/1  0  2020-02-27T21:04:34Z  [{'ip':'10.130.0.18'}]  ci-op-grg59-m-1.c.openshift-gce-devel-ci.internal
openshift-multus  multus-ctmqk                       1/1  4  2020-02-27T21:03:25Z  [{'ip':'10.0.0.4'}]     ci-op-grg59-m-0.c.openshift-gce-devel-ci.internal
openshift-multus  multus-k6p4r                       1/1  0  2020-02-27T21:03:25Z  [{'ip':'10.0.0.3'}]     ci-op-grg59-m-1.c.openshift-gce-devel-ci.internal
openshift-multus  multus-x8kwv                       1/1  4  2020-02-27T21:03:25Z  [{'ip':'10.0.0.6'}]     ci-op-grg59-m-2.c.openshift-gce-devel-ci.internal

We see some pods failing to get ready:
https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-network-operator/484/pull-ci-openshift-cluster-network-operator-master-e2e-gcp-ovn/282/artifacts/e2e-gcp-ovn/pods/openshift-multus_multus-ctmqk_kube-multus_previous.log

But others do work:
https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-network-operator/484/pull-ci-openshift-cluster-network-operator-master-e2e-gcp-ovn/282/artifacts/e2e-gcp-ovn/pods/openshift-multus_multus-k6p4r_kube-multus.log

This should be an all or nothing situation so I guess this is fine.

dcbw · 2020-02-28T15:53:48Z

/approve

openshift-ci-robot · 2020-02-28T15:56:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, dcbw, dougbtv, juanluisvaladas, pecameron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dcbw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-02-28T16:06:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-02-28T17:13:43Z

@dougbtv: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-ovn	`a650d6f`	link	`/test e2e-gcp-ovn`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2020-02-28T17:18:15Z

@dougbtv: All pull requests linked via external trackers have merged. Bugzilla bug 1805987 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1805987: Uses the readiness indicator file option for Multus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

smarterclayton · 2020-03-17T14:25:48Z

Did this go into 4.4 and 4.3?

danwinship · 2020-03-17T15:13:09Z

Yes. 4.4 backport is #507, 4.3 backport is #485

The cluster-network-operator should use the readiness indicator file …

fdf1f46

…option This helps to smooth out inconsistencies during an upgrade and helps Multus know openshift-sdn is ready.

openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2020

openshift-ci-robot requested review from JacobTanenbaum and dcbw February 18, 2020 21:10

openshift-ci-robot changed the title ~~Bug 1793635: Uses the readiness indicator file option for Multus~~ Bug 1785457: Uses the readiness indicator file option for Multus Feb 19, 2020

openshift-ci-robot assigned abhat Feb 21, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2020

pecameron reviewed Feb 27, 2020

View reviewed changes

openshift-ci-robot assigned pecameron Feb 27, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2020

Conditionalize multus --readiness-indicator-file

a650d6f

openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2020

pecameron reviewed Feb 27, 2020

View reviewed changes

bindata/network/multus/multus.yaml Show resolved Hide resolved

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2020

openshift-ci-robot changed the title ~~Bug 1785457: Uses the readiness indicator file option for Multus~~ Bug 1805987: Uses the readiness indicator file option for Multus Feb 28, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 28, 2020

danwinship mentioned this pull request Feb 28, 2020

Bug 1805774: Use the readiness indicator file option for Multus #507

Merged

pecameron reviewed Feb 28, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2020

openshift-ci-robot assigned juanluisvaladas Feb 28, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2020

openshift-merge-robot merged commit 161c3d7 into openshift:master Feb 28, 2020

Bug 1805987: Uses the readiness indicator file option for Multus #484

Bug 1805987: Uses the readiness indicator file option for Multus #484

Uh oh!

Conversation

dougbtv commented Feb 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 18, 2020

Uh oh!

openshift-ci-robot commented Feb 18, 2020

Uh oh!

danwinship commented Feb 19, 2020

Uh oh!

openshift-ci-robot commented Feb 19, 2020

Uh oh!

danwinship commented Feb 19, 2020

Uh oh!

openshift-bot commented Feb 20, 2020

Uh oh!

openshift-ci-robot commented Feb 20, 2020

Uh oh!

abhat commented Feb 21, 2020

Uh oh!

abhat commented Feb 21, 2020

Uh oh!

pecameron left a comment

Choose a reason for hiding this comment

Uh oh!

danwinship commented Feb 27, 2020

Uh oh!

danwinship commented Feb 27, 2020

Uh oh!

Uh oh!

danwinship commented Feb 27, 2020

Uh oh!

danwinship commented Feb 28, 2020

Uh oh!

danwinship commented Feb 28, 2020

Uh oh!

openshift-ci-robot commented Feb 28, 2020

Uh oh!

pecameron left a comment

Choose a reason for hiding this comment

Uh oh!

pecameron commented Feb 28, 2020

Uh oh!

pecameron commented Feb 28, 2020

Uh oh!

juanluisvaladas commented Feb 28, 2020

Uh oh!

dcbw commented Feb 28, 2020

Uh oh!

openshift-ci-robot commented Feb 28, 2020

Uh oh!

openshift-bot commented Feb 28, 2020

Uh oh!

openshift-ci-robot commented Feb 28, 2020

Uh oh!

openshift-ci-robot commented Feb 28, 2020

Uh oh!

smarterclayton commented Mar 17, 2020

Uh oh!

danwinship commented Mar 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

dougbtv commented Feb 18, 2020 •

edited

Loading