Skip to content

Conversation

@dougbtv
Copy link
Contributor

@dougbtv dougbtv commented Feb 18, 2020

In attempt to help cure some ills of upgrades.

Upstream PR @ k8snetworkplumbingwg/multus-cni#443

…dinessindicatorfile via entrypoint parameter
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 18, 2020
@openshift-ci-robot
Copy link
Contributor

@dougbtv: This pull request references Bugzilla bug 1793635, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1793635: Exposes readinessindicatorfile and uses wait.PollImmediate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 18, 2020
Copy link
Contributor

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2020
@s1061123
Copy link
Contributor

/test e2e-aws

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, s1061123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@s1061123
Copy link
Contributor

/test e2e-aws

@dougbtv dougbtv removed the request for review from squeed February 19, 2020 19:41
@dougbtv
Copy link
Contributor Author

dougbtv commented Feb 19, 2020

/retitle Exposes readinessindicatorfile and uses wait.PollImmediate

@openshift-ci-robot openshift-ci-robot changed the title Bug 1793635: Exposes readinessindicatorfile and uses wait.PollImmediate Exposes readinessindicatorfile and uses wait.PollImmediate Feb 19, 2020
@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 19, 2020
@openshift-ci-robot
Copy link
Contributor

@dougbtv: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Exposes readinessindicatorfile and uses wait.PollImmediate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants