Skip to content

Conversation

@crawford
Copy link
Contributor

@crawford crawford commented Aug 5, 2019

This series reports what installed the cluster. In order to do this, the
openshift-install ConfigMap, which is written by the installer when
doing an IPI install, is read. This ConfigMap is only injected during an
IPI installation and contains the invoker (e.g. username, Hive) as well
as the openshift-install version. The absence of this ConfigMap implies
a UPI installation. This data will allow us to determine whether a
cluster was installed IPI or UPI and, once CI and Hive have been
updated, whether the cluster was created by CI or Hive.

Because the data in this series never changes, it should compress
nicely so we shouldn't have to worry about wasting space.

If the data in the ConfigMap is missing, those label values are reported
as <missing>. That was used instead of an empty value in order to
distinguish between normal operation and an anomalous state. If the
openshift-install ConfigMap exists, it will have all of those fields
specified unless something were to erroneously remove them.

This is a backport of #213.

Back in 6c1716f, we dropped the direct dependency on glog, which
resulted in `dep ensure` showing the following warning:

    Warning: the following project(s) have [[constraint]] stanzas in
    Gopkg.toml:

      ✗  github.com/golang/glog

It also resulted in the constraint no longer being respected
(`[[override]]` is required for transitive dependencies). Since we have
been using a newer version of glog for almost two months now, I'm
dropping the constraint instead of converting into an override.
This series reports what installed the cluster. In order to do this, the
openshift-install ConfigMap, which is written by the installer when
doing an IPI install, is read. This ConfigMap is only injected during an
IPI installation and contains the invoker (e.g. username, Hive) as well
as the openshift-install version. The absence of this ConfigMap implies
a UPI installation. This data will allow us to determine whether a
cluster was installed IPI or UPI and, once CI and Hive have been
updated, whether the cluster was created by CI or Hive.

Because the data in this series never changes, it should compress
nicely so we shouldn't have to worry about wasting space.

If the data in the ConfigMap is missing, those label values are reported
as `<missing>`. That was used instead of an empty value in order to
distinguish between normal operation and an anomalous state. If the
openshift-install ConfigMap exists, it will have all of those fields
specified unless something were to erroneously remove them.
@openshift-ci-robot
Copy link
Contributor

@crawford: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

metrics: add cluster_installer series

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 5, 2019
@crawford
Copy link
Contributor Author

crawford commented Aug 5, 2019

The release architects have agreed that there is no need for a valid Bugzilla for this particular backport due to it being purely telemetry-focused and because QE isn't able to verify.

/bugzilla valid-bug

@crawford crawford added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 5, 2019
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, crawford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,crawford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crawford crawford added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 5, 2019
@openshift-merge-robot openshift-merge-robot merged commit 2f83693 into openshift:release-4.1 Aug 5, 2019
@crawford crawford deleted the metrics branch August 5, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants