-
Notifications
You must be signed in to change notification settings - Fork 213
metrics: add cluster_installer series #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Back in 6c1716f, we dropped the direct dependency on glog, which resulted in `dep ensure` showing the following warning: Warning: the following project(s) have [[constraint]] stanzas in Gopkg.toml: ✗ github.com/golang/glog It also resulted in the constraint no longer being respected (`[[override]]` is required for transitive dependencies). Since we have been using a newer version of glog for almost two months now, I'm dropping the constraint instead of converting into an override.
This series reports what installed the cluster. In order to do this, the openshift-install ConfigMap, which is written by the installer when doing an IPI install, is read. This ConfigMap is only injected during an IPI installation and contains the invoker (e.g. username, Hive) as well as the openshift-install version. The absence of this ConfigMap implies a UPI installation. This data will allow us to determine whether a cluster was installed IPI or UPI and, once CI and Hive have been updated, whether the cluster was created by CI or Hive. Because the data in this series never changes, it should compress nicely so we shouldn't have to worry about wasting space. If the data in the ConfigMap is missing, those label values are reported as `<missing>`. That was used instead of an empty value in order to distinguish between normal operation and an anomalous state. If the openshift-install ConfigMap exists, it will have all of those fields specified unless something were to erroneously remove them.
|
@crawford: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
The release architects have agreed that there is no need for a valid Bugzilla for this particular backport due to it being purely telemetry-focused and because QE isn't able to verify. /bugzilla valid-bug |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, crawford The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This series reports what installed the cluster. In order to do this, the
openshift-install ConfigMap, which is written by the installer when
doing an IPI install, is read. This ConfigMap is only injected during an
IPI installation and contains the invoker (e.g. username, Hive) as well
as the openshift-install version. The absence of this ConfigMap implies
a UPI installation. This data will allow us to determine whether a
cluster was installed IPI or UPI and, once CI and Hive have been
updated, whether the cluster was created by CI or Hive.
Because the data in this series never changes, it should compress
nicely so we shouldn't have to worry about wasting space.
If the data in the ConfigMap is missing, those label values are reported
as
<missing>. That was used instead of an empty value in order todistinguish between normal operation and an anomalous state. If the
openshift-install ConfigMap exists, it will have all of those fields
specified unless something were to erroneously remove them.
This is a backport of #213.