metrics: add cluster_installer series #213

crawford · 2019-06-26T23:04:52Z

This series reports what installed the cluster. In order to do this, the
openshift-install ConfigMap, which is written by the installer when
doing an IPI install, is read. This ConfigMap is only injected during an
IPI installation and contains the invoker (e.g. username, Hive) as well
as the openshift-install version. The absence of this ConfigMap implies
a UPI installation.

Because the data in this series never changes, it should compress
nicely so we shouldn't have to worry about wasting space.

crawford · 2019-06-26T23:05:20Z

Needs openshift/telemeter#189 before we can see the results.

crawford · 2019-06-26T23:10:33Z

/cc @smarterclayton

Back in 6c1716f, we dropped the direct dependency on glog, which resulted in `dep ensure` showing the following warning: Warning: the following project(s) have [[constraint]] stanzas in Gopkg.toml: ✗ github.com/golang/glog It also resulted in the constraint no longer being respected (`[[override]]` is required for transitive dependencies). Since we have been using a newer version of glog for almost two months now, I'm dropping the constraint instead of converting into an override.

crawford · 2019-07-20T07:17:41Z

/test ci/prow/e2e-aws

crawford · 2019-07-21T17:22:34Z

/test ci/prow/e2e-aws

crawford · 2019-07-21T17:24:44Z

/test e2e-aws

crawford · 2019-07-21T18:52:08Z

The metrics appear to be working:

/retitle metrics: add cluster_installer series

pkg/cvo/metrics.go

pkg/cvo/metrics_test.go

smarterclayton · 2019-07-22T18:38:48Z

pkg/cvo/metrics.go

 		}, []string{"name", "condition"}),
+		clusterInstaller: prometheus.NewGaugeVec(prometheus.GaugeOpts{
+			Name: "cluster_installer",
+			Help: "Reports the installation method for the cluster",


Is this supposed to have UPI vs IPI?

I think you'd want to return 1 / 0 if this is about IPI vs UPI, or 1 always if you have a label for UPI. Recommend documenting your labels in this.

Well, it's a bit more than that. You can derive UPI vs IPI from it, but you can also look at what invoked the installer (e.g. Hive). I can filled out that help text a bit more though.

Wait, so now I'm confused. Is type=UPI the label? Expected to see a test with that as an example (just so we know).

Might want to update metrics.md too once you finalize.

I've updated metrics.md. Can you let me know if it makes sense now?

pkg/cvo/metrics.go

This series reports what installed the cluster. In order to do this, the openshift-install ConfigMap, which is written by the installer when doing an IPI install, is read. This ConfigMap is only injected during an IPI installation and contains the invoker (e.g. username, Hive) as well as the openshift-install version. The absence of this ConfigMap implies a UPI installation. This data will allow us to determine whether a cluster was installed IPI or UPI and, once CI and Hive have been updated, whether the cluster was created by CI or Hive. Because the data in this series never changes, it should compress nicely so we shouldn't have to worry about wasting space. If the data in the ConfigMap is missing, those label values are reported as `<missing>`. That was used instead of an empty value in order to distinguish between normal operation and an anomalous state. If the openshift-install ConfigMap exists, it will have all of those fields specified unless something were to erroneously remove them.

smarterclayton · 2019-07-22T22:22:39Z

/lgtm

openshift-ci-robot · 2019-07-22T22:22:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [crawford,smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2019-07-23T02:52:02Z

/retest