Skip to content

pkg/cvo/sync_worker: Fix "successfull" -> "successful" typo #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 16, 2020
Merged

pkg/cvo/sync_worker: Fix "successfull" -> "successful" typo #346

openshift-merge-robot merged 1 commit into from
Apr 16, 2020

Conversation

@wking
Copy link
Member

@wking wking commented Apr 13, 2020

Typo from aceb5bc (#243).

@wking
pkg/cvo/sync_worker: Fix "successfull" -> "successful" typo
b2eee77 
Typo from aceb5bc (pkg: add precondition handlers and perform these
checks before accepting Update, 2019-08-26, openshift#243).
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2020
@vrutkovs
Copy link

vrutkovs commented Apr 16, 2020

/retest

@vrutkovs
Copy link

vrutkovs commented Apr 16, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrutkovs, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Apr 16, 2020

/override ci/prow/e2e-aws-upgrade
Change is in comment only

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 16, 2020

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-upgrade

Details

In response to this:

/override ci/prow/e2e-aws-upgrade
Change is in comment only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit d55d1a0 into openshift:master Apr 16, 2020
@wking wking deleted the successfull-typo branch April 16, 2020 23:32
@wking wking mentioned this pull request Apr 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crawford crawford Awaiting requested review from crawford

1 more reviewer

@vrutkovs vrutkovs vrutkovs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vrutkovs vrutkovs

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wking @vrutkovs @openshift-ci-robot @openshift-bot @sdodson @openshift-merge-robot