Skip to content

pkg/cvo/sync_worker: Log precondition handling #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wking wants to merge 3 commits into from
Closed

pkg/cvo/sync_worker: Log precondition handling #361

wking wants to merge 3 commits into from

Conversation

@wking
Copy link
Member

@wking wking commented Apr 24, 2020

To make it easier to debug precondition failures like rhbz#1827166.

This backports #360 to 4.4 for testing. It also backports #346 to avoid a rebase conflict.

wking added 2 commits April 24, 2020 11:41
@wking
pkg/cvo/sync_worker: Fix "successfull" -> "successful" typo
b9bbe1f 
Typo from aceb5bc (pkg: add precondition handlers and perform these
checks before accepting Update, 2019-08-26, openshift#243).
@wking
pkg/cvo/sync_worker: Log precondition handling
8171de0 
To make it easier to debug precondition failures like [1].

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1827166
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 24, 2020

@wking: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

pkg/cvo/sync_worker: Log precondition handling

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2020
This was referenced Apr 24, 2020
Merged
Closed
@wking
pkg/payload/precondition/clusterversion: Logging in the Upgradeable c…
6b59899 
…heck

So we can understand why this passes or fails more easily.
jottofar
jottofar reviewed Jun 29, 2020
View reviewed changes
pkg/payload/precondition/clusterversion/upgradeable.go
}
}

// if we are upgradeable==true we can always upgrade
Copy link
Contributor

@jottofar jottofar Jun 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always found this comment confusing, or at least overly simplistic, even before your changes. Can it be removed or enhanced.

Copy link
Member Author

@wking wking Jun 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is from #291, so orthogonal to my change. Since this PR is a already a backport, I'd rather not pick it up here. Feel free to file a separate master PR adjusting the wording.

@jottofar
Copy link
Contributor

jottofar commented Jun 29, 2020

/assign @jottofar

@jottofar
Copy link
Contributor

jottofar commented Jun 29, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 29, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 9, 2020

@wking: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e 6b59899 link /test e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson
Copy link
Member

sdodson commented Jul 9, 2020

/hold to stop unintentional ci tests, though maybe the invalid-bug flags are enough
Are we leaving this for testing purposes or should we close this?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2020
@wking
Copy link
Member Author

wking commented Jul 10, 2020

/close

We can re-open if/when we fix the master bug

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 10, 2020

@wking: Closed this PR.

Details

In response to this:

/close

We can re-open if/when we fix the master bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@crawford crawford Awaiting requested review from crawford

1 more reviewer

@jottofar jottofar jottofar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jottofar jottofar

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wking @openshift-ci-robot @jottofar @openshift-bot @sdodson