Bug 1848783: Expand supported set of probe field mutations #390

openshift-cherrypick-robot · 2020-06-19T00:13:18Z

This is an automated cherry-pick of #389

/assign wking

Before this change, only the initialDelaySeconds field of probes could be updated. This patch expands the set of supported fields to include all the other int32 fields of probes so that CVO will roll out such changes.

openshift-ci-robot · 2020-06-19T00:13:29Z

@openshift-cherrypick-robot: Bugzilla bug 1848729 has been cloned as Bugzilla bug 1848783. Retitling PR to link against new bug.
/retitle [release-4.4] [release-4.5] Bug 1848783: Expand supported set of probe field mutations

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-06-19T00:13:51Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1848783, which is invalid:

expected dependent Bugzilla bug 1848729 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2020-06-20T02:43:00Z

/lgtm

openshift-ci-robot · 2020-06-20T02:43:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-06-20T02:49:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-21T01:00:58Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-21T01:01:00Z

@openshift-bot: This pull request references Bugzilla bug 1848783, which is invalid:

expected dependent Bugzilla bug 1848729 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-22T01:00:57Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-22T01:00:59Z

@openshift-bot: This pull request references Bugzilla bug 1848783, which is invalid:

expected dependent Bugzilla bug 1848729 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-23T01:01:01Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-23T01:01:04Z

@openshift-bot: This pull request references Bugzilla bug 1848783, which is invalid:

expected dependent Bugzilla bug 1848729 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-24T01:01:17Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-24T01:01:20Z

@openshift-bot: This pull request references Bugzilla bug 1848783, which is invalid:

expected dependent Bugzilla bug 1848729 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-25T01:00:16Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-25T01:00:19Z

@openshift-bot: This pull request references Bugzilla bug 1848783, which is invalid:

expected dependent Bugzilla bug 1848729 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-26T01:00:54Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-26T01:00:57Z

@openshift-bot: This pull request references Bugzilla bug 1848783, which is invalid:

expected dependent Bugzilla bug 1848729 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-27T01:01:13Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-27T01:01:15Z

@openshift-bot: This pull request references Bugzilla bug 1848783, which is invalid:

expected dependent Bugzilla bug 1848729 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-28T01:00:57Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-28T01:00:59Z

@openshift-bot: This pull request references Bugzilla bug 1848783, which is invalid:

expected dependent Bugzilla bug 1848729 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-29T01:01:04Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-29T01:01:06Z

@openshift-bot: This pull request references Bugzilla bug 1848783, which is invalid:

expected dependent Bugzilla bug 1848729 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-30T01:00:59Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-30T01:01:01Z

@openshift-bot: This pull request references Bugzilla bug 1848783, which is invalid:

expected dependent Bugzilla bug 1848729 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2020-06-30T18:13:27Z

#389 VERIFIED by QE.

/bugzilla refresh

openshift-ci-robot · 2020-06-30T18:13:33Z

@wking: This pull request references Bugzilla bug 1848783, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.z) matches configured target release for branch (4.4.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1848729 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1848729 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-07-02T19:16:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-02T19:29:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-03T00:01:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-07-03T01:23:02Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/cluster-version-operator#390. Bugzilla bug 1848783 has been moved to the MODIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Expand supported set of probe field mutations

0874e0c

Before this change, only the initialDelaySeconds field of probes could be updated. This patch expands the set of supported fields to include all the other int32 fields of probes so that CVO will roll out such changes.

openshift-ci-robot assigned wking Jun 19, 2020

openshift-cherrypick-robot mentioned this pull request Jun 19, 2020

Bug 1848729: Expand supported set of probe field mutations #389

Merged

openshift-ci-robot requested review from crawford and smarterclayton June 19, 2020 00:13

openshift-ci-robot changed the title ~~[release-4.4] [release-4.5] Bug 1848729: Expand supported set of probe field mutations~~ [release-4.4] [release-4.5] Bug 1848783: Expand supported set of probe field mutations Jun 19, 2020

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 19, 2020

wking changed the title ~~[release-4.4] [release-4.5] Bug 1848783: Expand supported set of probe field mutations~~ Bug 1848783: Expand supported set of probe field mutations Jun 19, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2020

wking mentioned this pull request Jun 22, 2020

[release-4.4] Bug 1848783: Expand supported set of probe field mutations #391

Closed

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 30, 2020

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 2, 2020

openshift-merge-robot merged commit e84a52a into openshift:release-4.4 Jul 3, 2020

openshift-ci-robot mentioned this pull request Jul 3, 2020

[release-4.4] Bug 1845635: etcd-quorum-guard: update containers section in deployment.yaml openshift/machine-config-operator#1820

Merged

Bug 1848783: Expand supported set of probe field mutations #390

Bug 1848783: Expand supported set of probe field mutations #390

Uh oh!

Conversation

openshift-cherrypick-robot commented Jun 19, 2020

Uh oh!

openshift-ci-robot commented Jun 19, 2020

Uh oh!

openshift-ci-robot commented Jun 19, 2020

Uh oh!

wking commented Jun 20, 2020

Uh oh!

openshift-ci-robot commented Jun 20, 2020

Uh oh!

openshift-bot commented Jun 20, 2020

Uh oh!

openshift-bot commented Jun 21, 2020

Uh oh!

openshift-ci-robot commented Jun 21, 2020

Uh oh!

openshift-bot commented Jun 22, 2020

Uh oh!

openshift-ci-robot commented Jun 22, 2020

Uh oh!

openshift-bot commented Jun 23, 2020

Uh oh!

openshift-ci-robot commented Jun 23, 2020

Uh oh!

openshift-bot commented Jun 24, 2020

Uh oh!

openshift-ci-robot commented Jun 24, 2020

Uh oh!

openshift-bot commented Jun 25, 2020

Uh oh!

openshift-ci-robot commented Jun 25, 2020

Uh oh!

openshift-bot commented Jun 26, 2020

Uh oh!

openshift-ci-robot commented Jun 26, 2020

Uh oh!

openshift-bot commented Jun 27, 2020

Uh oh!

openshift-ci-robot commented Jun 27, 2020

Uh oh!

openshift-bot commented Jun 28, 2020

Uh oh!

openshift-ci-robot commented Jun 28, 2020

Uh oh!

openshift-bot commented Jun 29, 2020

Uh oh!

openshift-ci-robot commented Jun 29, 2020

Uh oh!

openshift-bot commented Jun 30, 2020

Uh oh!

openshift-ci-robot commented Jun 30, 2020

Uh oh!

wking commented Jun 30, 2020

Uh oh!

openshift-ci-robot commented Jun 30, 2020

Uh oh!

openshift-bot commented Jul 2, 2020

Uh oh!

openshift-bot commented Jul 2, 2020

Uh oh!

openshift-bot commented Jul 3, 2020

Uh oh!

openshift-ci-robot commented Jul 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants