Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #383

/assign ironcladlou

Before this change, only the initialDelaySeconds field of probes could be
updated. This patch expands the set of supported fields to include all the
other int32 fields of probes so that CVO will roll out such changes.
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1847672 has been cloned as Bugzilla bug 1849619. Retitling PR to link against new bug.
/retitle [release-4.4] Bug 1849619: Expand supported set of probe field mutations

Details

In response to this:

[release-4.4] Bug 1847672: Expand supported set of probe field mutations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Bug 1847672: Expand supported set of probe field mutations [release-4.4] Bug 1849619: Expand supported set of probe field mutations Jun 22, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 22, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1849619, which is invalid:

  • expected dependent Bugzilla bug 1847672 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
  • expected dependent Bugzilla bug 1847672 to target a release in 4.5.0, 4.5.z, but it targets "4.6.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.4] Bug 1849619: Expand supported set of probe field mutations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ironcladlou
Copy link
Contributor

/retitle [release-4.4] Bug 1848783: Expand supported set of probe field mutations

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Bug 1849619: Expand supported set of probe field mutations [release-4.4] Bug 1848783: Expand supported set of probe field mutations Jun 22, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1848783, which is invalid:

  • expected dependent Bugzilla bug 1848729 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.4] Bug 1848783: Expand supported set of probe field mutations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Jun 22, 2020

/close

We already have #390 for 4.4.

@openshift-ci-robot
Copy link
Contributor

@wking: Closed this PR.

Details

In response to this:

/close

We already have #390 for 4.4.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1848783. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

[release-4.4] Bug 1848783: Expand supported set of probe field mutations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants