Changes to verify package in preparation for move to library-go #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
jottofar
force-pushed
the
ota-190-verify-reuse-prep
branch
from
5214063 to
e792735
Compare
Contributor
Author
|
/assign @wking |
wking
reviewed
Jul 22, 2020
wking
reviewed
Jul 22, 2020
wking
reviewed
Jul 22, 2020
wking
reviewed
Jul 22, 2020
wking
reviewed
Jul 22, 2020
jottofar
force-pushed
the
ota-190-verify-reuse-prep
branch
from
e792735 to
2bde02f
Compare
wking
reviewed
Jul 23, 2020
jottofar
force-pushed
the
ota-190-verify-reuse-prep
branch
from
2bde02f to
f16cb2d
Compare
Contributor
Author
|
@wking I went back to my original approach which adds a method LoadConfigMapVerifierDataFromManifest, to be used by oc, and allows the prefix constants to remain internal. Note that I added k8s decode/encode to util which is used by new method. |
Contributor
Author
|
/retest |
wking
reviewed
Jul 27, 2020
wking
reviewed
Jul 27, 2020
jottofar
force-pushed
the
ota-190-verify-reuse-prep
branch
from
dd8df78 to
eeb33e9
Compare
Contributor
Author
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
jottofar
force-pushed
the
ota-190-verify-reuse-prep
branch
4 times, most recently
from
bb23989 to
f929d03
Compare
openshift-ci-robot
added
the
needs-rebase
Contributor
Author
|
/unhold |
openshift-ci-robot
removed
the
do-not-merge/hold
jottofar
force-pushed
the
ota-190-verify-reuse-prep
branch
from
f929d03 to
41c79e9
Compare
openshift-ci-robot
removed
the
needs-rebase
Contributor
Author
|
/retest |
wking
reviewed
Aug 8, 2020
wking
reviewed
Aug 8, 2020
jottofar
force-pushed
the
ota-190-verify-reuse-prep
branch
from
b39b35f to
33b8eb8
Compare
Contributor
Author
|
/test unit |
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
wking
reviewed
Aug 11, 2020
wking
reviewed
Aug 11, 2020
wking
reviewed
Aug 11, 2020
wking
reviewed
Aug 11, 2020
wking
reviewed
Aug 11, 2020
jottofar
force-pushed
the
ota-190-verify-reuse-prep
branch
from
33b8eb8 to
d1d12ab
Compare
Contributor
Author
|
/retest |
vrutkovs
reviewed
Aug 13, 2020
The CVO verify package will be moved to library-go for reuse by 'oc adm release mirror' and CVO. Changes are being made here in CVO before the move to provide a cleaner move to library-go. Logic to create verifier was broken out into a new configmap method NewFromManifests. This method uses k8s encoding and as a result existing test cases had to be changed from creating manifests from from declarations within the test cases itself to creating them from config map files. In this manner the lib/Manifest object is properly created with its Raw bytes field populated.
jottofar
force-pushed
the
ota-190-verify-reuse-prep
branch
from
d1d12ab to
472cc1b
Compare
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
Author
|
/test unit |
wking
reviewed
Aug 18, 2020
Member
|
One unit test I don't understand, otherwise looks good to me. Pull the hold if I'm just confused, or if you want to punt a fix to follow-up work. /lgtm |
openshift-ci-robot
added
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jottofar, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/unhold |
openshift-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to verify package in preparation for move to library-go
The CVO verify package will be moved to library-go for reuse by 'oc adm release mirror' and CVO. Changes are being made here in CVO before the move to provide a cleaner move to library-go.
Logic to create verifier was broken out into a new configmap method NewFromManifests. This method uses k8s encoding and as a result existing test cases had to be changed from creating manifests from from declarations within the test cases itself to creating them from config map files. In this manner the lib/Manifest object is properly created with its Raw bytes field populated.