Create a resuable verify package for image release verification #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
jottofar
force-pushed
the
ota-cvo-and-oc-reuse
branch
2 times, most recently
from
5ed2982 to
7ec1baf
Compare
Contributor
Author
|
/retest |
Contributor
Author
|
/retitle Create a resuable verify package for image release verification |
openshift-ci-robot
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
jottofar
force-pushed
the
ota-cvo-and-oc-reuse
branch
from
7ec1baf to
f2a7915
Compare
Contributor
Author
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
jottofar
force-pushed
the
ota-cvo-and-oc-reuse
branch
4 times, most recently
from
a8f7bc1 to
8ff8d9f
Compare
Contributor
Author
|
Created new test cases in |
Contributor
Author
|
/unhold |
openshift-ci-robot
removed
the
do-not-merge/hold
jottofar
force-pushed
the
ota-cvo-and-oc-reuse
branch
from
8ff8d9f to
d444be4
Compare
jottofar
force-pushed
the
ota-cvo-and-oc-reuse
branch
from
d444be4 to
8a3b061
Compare
wking
reviewed
Aug 21, 2020
wking
reviewed
Aug 21, 2020
wking
reviewed
Aug 21, 2020
wking
reviewed
Aug 21, 2020
jottofar
force-pushed
the
ota-cvo-and-oc-reuse
branch
from
8a3b061 to
892e7fb
Compare
Both the oc client application and the CVO do image release verification. Image release verification was recently added to the oc client and at that time any code required was simply copied from the CVO were it was originally developed. This change moves the code required for image release verification, the CVO package verify, from the CVO into library-go for reuse by CVO and the oc client application and applies any required changes to make it reusabe by both.
jottofar
force-pushed
the
ota-cvo-and-oc-reuse
branch
from
892e7fb to
c43c2cb
Compare
wking
approved these changes
Aug 24, 2020
Member
wking
left a comment
wking
left a comment
There was a problem hiding this comment.
$ git --no-pager -C cluster-version-operator log -1 --oneline
34010292 (HEAD -> master, wking/master, origin/release-4.7, origin/release-4.6, origin/master, origin/HEAD) Merge pull request #439 from wking/fix-component-regexp-docs
$ git --no-pager -C library-go log -1 --oneline
c43c2cb20 (HEAD, origin/pr/837) Create a resuable verify package for image release verification
$ diff -ru cluster-version-operator/pkg/verify library-go/pkg/verify
...nothing serious.../lgtm
/approve
Member
|
/close In case this will help Prow notice #868. |
|
@wking: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Member
|
/reopen |
|
@wking: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Member
|
/approve |
Member
Contributor
|
golang/x dep is ok /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, jottofar, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
wking
added a commit
to wking/openshift-library-go
that referenced
this pull request
May 19, 2022
This function calls the callback for each signature, it doesn't return a list. Fixes a godoc from the original implementation in c43c2cb (Create a resuable verify package for image release verification, 2020-07-16, openshift#837).
wking
added a commit
to wking/openshift-library-go
that referenced
this pull request
Nov 16, 2023
Typo slipped in when the file was created in c43c2cb (Create a resuable verify package for image release verification, 2020-07-16, openshift#837).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the oc client application and the CVO do image release verification. Image release verification was recently added to the oc client and at that time any code required was simply copied from the CVO were it was originally developed. This change moves the code required for image release verification, the CVO package verify, from the CVO into library-go for reuse by CVO and the oc client application and applies any required changes to make it reusable by both.