Skip to content

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Aug 5, 2020

This resolves a problem where status doesn't reflect the payload actually being applied.
wking is chasing an alternative using different graceful leader election rules.
It would also be resolved by synchronously writing the status out when we start applying a new payload.

This resolves a problem where status doesn't reflect the payload actually being applied.
wking is chasing an alternative using different graceful leader election rules.
It would also be resolved by synchronously writing the status out when we start applying a new payload.
@deads2k deads2k force-pushed the tune-down-leader-election branch from d15e14e to af54374 Compare August 5, 2020 18:42
@wking
Copy link
Member

wking commented Aug 5, 2020

/retitle Bug 1843505: Have the leader election use faster defaults

Not a fix for the bug, but it will be related to the bug and something we end up backporting if we backport the bugfix to previous versions.

@openshift-ci-robot openshift-ci-robot changed the title Have the leader election use faster defaults. Bug 1843505: Have the leader election use faster defaults Aug 5, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 5, 2020
@openshift-ci-robot
Copy link
Contributor

@deads2k: This pull request references Bugzilla bug 1843505, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1843505: Have the leader election use faster defaults

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smarterclayton
Copy link
Contributor

/retest

@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2020
@openshift-merge-robot openshift-merge-robot merged commit 09c065b into openshift:master Aug 5, 2020
@openshift-ci-robot
Copy link
Contributor

@deads2k: Some pull requests linked via external trackers have merged: openshift/cluster-version-operator#426. The following pull requests linked via external trackers have not merged:

Details

In response to this:

Bug 1843505: Have the leader election use faster defaults

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants