install/0000_90_cluster-version-operator_02_servicemonitor: Add ClusterReleaseNotAccepted #906
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erReleaseNotAccepted We grew a ReleaseAccepted condition in 7221c93 (pkg/cvo: Separate payload load from payload apply, 2021-10-28, openshift#683), which landed in 4.11 [1] and was backported to 4.10.8 [2]. However, in order to notice a ReleaseAccepted!=True condition, users would need to be checking 'oc adm upgrade' [3] or watching the web-console interface [4]. With this change, we add an alert, so admins can have push-notification to supplement those polling approaches. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1822752#c49 [2]: https://bugzilla.redhat.com/show_bug.cgi?id=2064991#c7 [3]: https://bugzilla.redhat.com/show_bug.cgi?id=2065507 [4]: https://issues.redhat.com//browse/OCPBUGS-3069
openshift-ci
bot
added
the
approved
Member
Author
sounds like a build-cluster thing to me. /retest |
Member
Author
|
/retest |
Contributor
|
@wking: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
added a commit
to wking/cluster-version-operator
that referenced
this pull request
Oct 31, 2023
…om ${{
Fixing a ClusterOperatorDown typo from bbcc33d (pkg/cvo/metrics:
Add 'reason' to cluster_operator_up, 2022-11-21, openshift#868) that I'd
carried forward into ClusterReleaseNotAccepted in 734b9c5
(install/0000_90_cluster-version-operator_02_servicemonitor: Add
ClusterReleaseNotAccepted, 2023-02-23, openshift#906) [1].
[1]: https://issues.redhat.com/browse/OCPBUGS-8079
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/cluster-version-operator
that referenced
this pull request
Mar 13, 2024
…om ${{
Fixing a ClusterOperatorDown typo from bbcc33d (pkg/cvo/metrics:
Add 'reason' to cluster_operator_up, 2022-11-21, openshift#868) that I'd
carried forward into ClusterReleaseNotAccepted in 734b9c5
(install/0000_90_cluster-version-operator_02_servicemonitor: Add
ClusterReleaseNotAccepted, 2023-02-23, openshift#906) [1].
[1]: https://issues.redhat.com/browse/OCPBUGS-8079
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We grew a
ReleaseAcceptedcondition in 7221c93 (#683), which landed in 4.11 and was backported to 4.10.8. However, in order to notice aReleaseAccepted!=Truecondition, users would need to be checkingoc adm upgradeor watching the web-console interface. With this change, we add an alert, so admins can have push-notification to supplement those polling approaches.