Skip to content

bug 1797788: describe how the a single test image can still be produced #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deads2k wants to merge 1 commit into from
Closed

bug 1797788: describe how the a single test image can still be produced #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions ...ements/testing/extended-platform-tests.md → enhancements/testing/openshift-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
title: extended-platform-tests
title: openshift-tests
authors:
- "@deads2k"
reviewers:
Expand All @@ -17,7 +17,7 @@ replaces:
superseded-by:
---

# Extended Platform Tests
# OpenShift Tests

## Release Signoff Checklist

Expand Down Expand Up @@ -63,11 +63,24 @@ Doing this...

### The realistic, land in 4.4 approach

1. Create openshift/extended-platform-tests
1. Create openshift/openshift-tests
2. Prime the repo with a `git filter-branch` from origin to keep the history of the tests we have.
3. Create a simple `go.mod` based vendoring and library-go based `Makefile`.
4. Produce images.
5. Create CI template for new `extended-platform-tests run openshift/conformance/parallel` and `extended-platform-tests run openshift/conformance/serial`.
4. Produce images.
1. openshift/origin will start producing an openshift-kubernetes-tests image that has `openshift-tests` binary.
2. openshift/origin will rename the existing `openshift-tests` binary to `openshift-kubernetes-tests` and create
a new `openshift-tests` binary which looks in a path and runs all the `openshift-*-tests` binaries and aggregates
the junit results. These new binaries will go into both the existing openshift-tests image and the new openshift-kubernetes-tests image.
3. a new job for openshift/origin will be created to run *just* openshift-kubernetes-tests image and binary.
4. the openshift/openshift-tests repo will create a new binary called `openshift-openshift-tests`. It will temporarily
create an extended-platform-tests image based on openshift-kubernetes-tests that layers in the `openshift-openshift-tests`
binary.
5. confirm that that the extended-platform-tests image runs all tests from openshift-kubernetes-tests and openshift-openshift-tests.
we can do this with a CI job ont he openshift/openshift-tests repo
6. coordinate a swap of ownership of the openshift-tests image. the extended-platform-tests image will be renamed to openshift-tests
and openshift/origin will stop creating an openshift-tests image.

5. Create CI template for new `openshift-tests run openshift/conformance/parallel` and `openshift-tests run openshift/conformance/serial`.
Copy link
Contributor

@sallyom sallyom Feb 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think a new template is necessary, have to edit the TEST_COMMAND for current jobs is all

6. Wire the new jobs into the repos.

### The ideal "handle the testing gaps we actually need to fix" approach
Expand Down Expand Up @@ -96,7 +109,7 @@ from the repository of their choosing.
### Risks and Mitigations

1. The creation of a test ghetto that no one cares about.
By moving existing non-kubernetes tests to extended-platform-tests, we can ensure
By moving existing non-kubernetes tests to openshift-tests, we can ensure
that teams that are familiar with how the test framework works have a vested interest in the new repo being successful.

### Version Skew Strategy
Expand Down