Skip to content

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 23, 2020

To keep a single test image, with two binaries, with a union-ing binary that can handle an arbitrary number of properly named test binaries.

/assign @smarterclayton

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 23, 2020
@deads2k deads2k changed the title describe how the a single test image can still be produced bug 1797788: describe how the a single test image can still be produced Feb 3, 2020
@openshift-ci-robot
Copy link

@deads2k: This pull request references Bugzilla bug 1797788, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

bug 1797788: describe how the a single test image can still be produced

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 3, 2020
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm, but I'll leave final sign-off to @smarterclayton

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

6. coordinate a swap of ownership of the openshift-tests image. the extended-platform-tests image will be renamed to openshift-tests
and openshift/origin will stop creating an openshift-tests image.

5. Create CI template for new `openshift-tests run openshift/conformance/parallel` and `openshift-tests run openshift/conformance/serial`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think a new template is necessary, have to edit the TEST_COMMAND for current jobs is all

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 28, 2020
@deads2k
Copy link
Contributor Author

deads2k commented Oct 26, 2020

this is going to happen in some other way.

@deads2k deads2k closed this Oct 26, 2020
@openshift-ci-robot
Copy link

@deads2k: This pull request references Bugzilla bug 1797788. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

bug 1797788: describe how the a single test image can still be produced

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants