disabled cluster relocation when using managed DNS #1006
Conversation
openshift-ci-robot
added
the
approved
|
Are they neutered? After attempt #2 my understanding was that the remaining change just lets reconcile continue if ClusterDeployment is gone. |
Yes, it lets the reconcile continue, which it should not in the case where the DNSZone has been copied to the destination cluster but the ClusterDeployment has not yet. |
Since the dnszone and dnsendpoint controllers have had their logic for handling relocated clusters neutered, then cluster relocation must be disabled when using managed DNS.
staebler
force-pushed
the
disabled_recolate_for_managed_dns
branch
from
0c24ff6 to
8955731
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 participants
Since the dnszone and dnsendpoint controllers have had their logic for handling relocated clusters neutered, then cluster relocation must be disabled when using managed DNS.