Template for creating ClusterDeployments and spawning dummy jobs in the controller #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XL
Member
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installer's InstallConfig is not currently usable as a Kube type, so it had to be copied in, with a few minor modifications. (remove some objectmeta, change the IPNet usage to string, and critically ensure the auto-generated methods are present for Kube such as DeepCopyInto) I am pursuing what we should do with this long term with installer team, but this gets us moving now and we can change easily in future.
ClusterDeployment template allows creating with your desired admin info and SSH key.
Controller updated to create a dummy job that just passes, associated with the cluster deployment. (automatically cleaned up and triggering resyncs of the cluster deployment on job updates changes)