Skip to content

Syncset Testing PR #2 #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abutcher merged 3 commits into from
Dec 3, 2022
Merged

Syncset Testing PR #2 #1923

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af4ab59
Revert "Revert "Merge pull request #1903 from dlom/HIVE-2038""
dlom Dec 1, 2022
8706081
Add bonus logging for stage
dlom Dec 1, 2022
d272266
Revert "Revert "Revert "Merge pull request #1903 from dlom/HIVE-2038"""
dlom Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/controller/clustersync/clustersync_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,16 +924,17 @@ func applyToTargetCluster(
return err
}

logger.WithField("uid", obj.GetUID()).WithField("resource_version", obj.GetResourceVersion()).Info("attempting to apply resource")
applyResult, err := applyFn(bytes)
// Record the amount of time we took to apply this specific resource. When combined with the metric for duration of
// our kube client requests, we can get an idea how much time we're spending cpu bound vs network bound.
applyTime := metav1.Now().Sub(startTime).Seconds()
if err != nil {
logger.WithError(err).Warn("error applying resource")
logger.WithError(err).WithField("uid", obj.GetUID()).WithField("resource_version", obj.GetResourceVersion()).WithField("applyTime", applyTime).Warn("error applying resource")
metricResourcesApplied.WithLabelValues(applyFnMetricLabel, metricResultError).Inc()
metricTimeToApplySyncSetResource.WithLabelValues(applyFnMetricLabel, metricResultError).Observe(applyTime)
} else {
logger.WithField("applyResult", applyResult).Debug("resource applied")
logger.WithField("applyResult", applyResult).WithField("uid", obj.GetUID()).WithField("resource_version", obj.GetResourceVersion()).WithField("applyTime", applyTime).Info("resource applied")
metricResourcesApplied.WithLabelValues(applyFnMetricLabel, metricResultSuccess).Inc()
metricTimeToApplySyncSetResource.WithLabelValues(applyFnMetricLabel, metricResultSuccess).Observe(applyTime)
}
Expand Down