Skip to content

Syncset Testing PR #2 #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abutcher merged 3 commits into from
Dec 3, 2022
Merged

Syncset Testing PR #2 #1923

abutcher merged 3 commits into from
Dec 3, 2022

Conversation

@dlom
Copy link
Contributor

@dlom dlom commented Nov 30, 2022 •
edited
Loading

This PR reverts the functional changes of #1921 but retains the logging. This PR is a superset of #1921 and should be merged after it, but before #1924 (which is a superset of this PR).

@openshift-ci openshift-ci bot requested review from abutcher and suhanime November 30, 2022 20:44
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2022
@dlom dlom mentioned this pull request Nov 30, 2022
Merged
@codecov
Copy link

codecov bot commented Nov 30, 2022 •
edited
Loading

Codecov Report

Merging #1923 (d272266) into master (a24b27f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1923   +/-   ##
=======================================
  Coverage   42.15%   42.16%           
=======================================
  Files         366      366           
  Lines       34045    34046    +1     
=======================================
+ Hits        14353    14354    +1     
  Misses      18485    18485           
  Partials     1207     1207
Impacted Files Coverage Δ
...g/controller/clustersync/clustersync_controller.go 75.81% <100.00%> (+0.03%) ⬆️

@dlom
Copy link
Contributor Author

dlom commented Dec 1, 2022

/retest

@dlom dlom force-pushed the HIVE-2038-again-2 branch from 88ee5ee to 044e654 Compare December 1, 2022 18:50
@dlom dlom force-pushed the HIVE-2038-again-2 branch from 044e654 to ee33842 Compare December 1, 2022 20:46
@dlom dlom force-pushed the HIVE-2038-again-2 branch from ee33842 to d272266 Compare December 1, 2022 20:52
@dlom dlom mentioned this pull request Dec 1, 2022
Merged
@dlom
Copy link
Contributor Author

dlom commented Dec 1, 2022

/retest

@2uasimojo
Copy link
Member

2uasimojo commented Dec 2, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2022
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 2, 2022

/retest-required

Remaining retests: 0 against base HEAD d191451 and 2 for PR HEAD d272266 in total

@2uasimojo
Copy link
Member

2uasimojo commented Dec 2, 2022

/retest

1 similar comment
@2uasimojo
Copy link
Member

2uasimojo commented Dec 2, 2022

/retest

@2uasimojo
Copy link
Member

2uasimojo commented Dec 2, 2022

/test images

@jupierce
Copy link

jupierce commented Dec 2, 2022

/retest

1 similar comment
@2uasimojo
Copy link
Member

2uasimojo commented Dec 2, 2022

/retest

@jupierce
Copy link

jupierce commented Dec 2, 2022

/test e2e

1 similar comment
@jupierce
Copy link

jupierce commented Dec 2, 2022

/test e2e

@jupierce
Copy link

jupierce commented Dec 2, 2022

/test e2e-pool

@abutcher
Copy link
Member

abutcher commented Dec 2, 2022

/test e2e

@dlom
Copy link
Contributor Author

dlom commented Dec 3, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2022

@dlom: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e d272266 link true /test e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abutcher
Copy link
Member

abutcher commented Dec 3, 2022

Force merging, #1924 undoes this change

@abutcher abutcher merged commit cc8c40c into openshift:master Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abutcher abutcher Awaiting requested review from abutcher

@suhanime suhanime Awaiting requested review from suhanime

Assignees

@2uasimojo 2uasimojo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dlom @2uasimojo @openshift-ci-robot @jupierce @abutcher