Skip to content

Conversation

@huangmingxia
Copy link
Contributor

@huangmingxia huangmingxia commented Feb 28, 2025

  1. Set managed DNS to false.
    Currently, managed DNS only supports AWS, GCP, and Azure clouds.

  2. This function get_vips() uses echo to obtain the value, and the echo output includes a timestamp.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: huangmingxia
Once this PR has been reviewed and has the lgtm label, please assign 2uasimojo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


vip=$(sed -n "${idx}p" "$vips")
echo "$vip"
printf "%s" "$vip"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the format string is redundant

Suggested change
printf "%s" "$vip"
printf "$vip"

...but for that matter, so is the temporary variable. We could just consolidate with the previous line:

Suggested change
printf "%s" "$vip"
sed -n "${idx}p" "$vips"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comment! ^^

Copy link
Member

@2uasimojo 2uasimojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe Mark is still working on this stuff.

@dlom
Copy link
Contributor

dlom commented Mar 3, 2025

This works for me. As soon as vsphere CI is working again we can merge this (I'll hold a local copy in my branch)

@huangmingxia
Copy link
Contributor Author

This works for me. As soon as vsphere CI is working again we can merge this (I'll hold a local copy in my branch)

Sounds good!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2025

@huangmingxia: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@2uasimojo
Copy link
Member

@dlom have you already incorporated this into #2541?

@dlom
Copy link
Contributor

dlom commented Apr 29, 2025

Yes, this PR can be closed. Thank you @huangmingxia

@dlom dlom closed this May 14, 2025
@huangmingxia
Copy link
Contributor Author

Hi @dlom My pleasure!
Sorry it took me so long to reply! Your message got buried in my overflowing inbox until I cleaned it up just now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants