-
Notifications
You must be signed in to change notification settings - Fork 253
Update vSphere e2e parameter configuration #2590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: huangmingxia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
||
| vip=$(sed -n "${idx}p" "$vips") | ||
| echo "$vip" | ||
| printf "%s" "$vip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the format string is redundant
| printf "%s" "$vip" | |
| printf "$vip" |
...but for that matter, so is the temporary variable. We could just consolidate with the previous line:
| printf "%s" "$vip" | |
| sed -n "${idx}p" "$vips" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your comment! ^^
2uasimojo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe Mark is still working on this stuff.
|
This works for me. As soon as vsphere CI is working again we can merge this (I'll hold a local copy in my branch) |
Sounds good! |
|
@huangmingxia: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Yes, this PR can be closed. Thank you @huangmingxia |
|
Hi @dlom My pleasure! |
Set managed DNS to false.
Currently, managed DNS only supports AWS, GCP, and Azure clouds.
This function
get_vips()usesechoto obtain the value, and theechooutput includes a timestamp.