HIVE-2270: proper e2e support for vSphere

[dlom]

xref: HIVE-2270

corresponding CI PR: openshift/release#58886

[openshift-ci-robot]

@dlom: This pull request references HIVE-2270 which is a valid jira issue.

Details

In response to this:

xref: HIVE-2270

corresponding CI PR: openshift/release#58886

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@dlom: This pull request references HIVE-2270 which is a valid jira issue.

Details

In response to this:

xref: HIVE-2270

corresponding CI PR: openshift/release#58886

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dlom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Attention: Patch coverage is 30.43478% with 128 lines in your changes missing coverage. Please review.

Project coverage is 50.05%. Comparing base (aaacfde) to head (2ccf2a4).
Report is 14 commits behind head on master.

Files with missing lines	Patch %	Lines
...om/openshift/hive/apis/hive/v1/vsphere/platform.go	0.00%	47 Missing ⚠️
pkg/clusterresource/vsphere.go	59.42%	28 Missing ⚠️
contrib/pkg/createcluster/create.go	0.00%	13 Missing ⚠️
.../clusterdeployment/clusterdeployment_controller.go	0.00%	9 Missing and 1 partial ⚠️
pkg/controller/utils/credentials.go	0.00%	9 Missing ⚠️
contrib/pkg/deprovision/vsphere.go	0.00%	8 Missing ⚠️
pkg/install/generate.go	0.00%	6 Missing ⚠️
...g/controller/clusterpool/clusterpool_controller.go	0.00%	3 Missing ⚠️
pkg/controller/machinepool/vsphereactuator.go	81.81%	1 Missing and 1 partial ⚠️
.../v1/clusterdeployment_validating_admission_hook.go	66.66%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2541      +/-   ##
==========================================
- Coverage   50.14%   50.05%   -0.10%     
==========================================
  Files         281      282       +1     
  Lines       33292    33354      +62     
==========================================
  Hits        16695    16695              
- Misses      15260    15325      +65     
+ Partials     1337     1334       -3     

Files with missing lines	Coverage Δ
...s/hive/v1/clusterpool_validating_admission_hook.go	80.85% <100.00%> (ø)
...hift/hive/apis/hive/v1/clusterdeprovision_types.go	0.00% <ø> (ø)
pkg/controller/machinepool/vsphereactuator.go	69.81% <81.81%> (-3.45%)	⬇️
.../v1/clusterdeployment_validating_admission_hook.go	86.29% <66.66%> (+0.66%)	⬆️
...g/controller/clusterpool/clusterpool_controller.go	58.26% <0.00%> (+0.21%)	⬆️
pkg/install/generate.go	47.14% <0.00%> (-0.40%)	⬇️
contrib/pkg/deprovision/vsphere.go	0.00% <0.00%> (ø)
pkg/controller/utils/credentials.go	0.00% <0.00%> (ø)
.../clusterdeployment/clusterdeployment_controller.go	65.92% <0.00%> (-0.36%)	⬇️
contrib/pkg/createcluster/create.go	0.00% <0.00%> (ø)
... and 2 more

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dlom]

/test e2e-vsphere

[dlom]

/test e2e-vsphere

[dlom]

/test e2e-vsphere

[dlom]

/test e2e-vsphere

[dlom]

/test e2e-vsphere

[dlom]

/test e2e-vsphere

[dlom]

/test e2e-vsphere

[dlom]

/test e2e-vsphere

[dlom]

/retitle HIVE-2270: proper e2e support for vSphere

[dlom]

/retest

[dlom]

/retest

[2uasimojo]

/test e2e-vsphere

...now that openshift/release#64095 has landed.

[dlom]

/test e2e-vsphere

[openshift-ci]

@dlom: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[2uasimojo]

Live review notes:

• Split out the API etc. changes (they'll go toward the zonal support epic).
• This PR to contain only e2e-common.sh (and e2e-test.sh if necessary) and hiveutil create cluster additional CLI opt for the platform spec JSON blob.
• Subsume $SHARED_DIR/*.txt file processing into the job spec in the release repo, so by the time we hit e2e it's just env vars (but make sure the contents, esp the platform spec json blob, are clean).
• Great work getting this green!