asset/cluster: inject installer info when creating #1890
Conversation
openshift-ci-robot
added
size/M
|
/cc @smarterclayton |
OpenShift telemetry is currently unable to report _how_ a cluster was installed (i.e. user-provisioned vs installer-provisioned). We currently use a heuristic to try to determine this information. This patch adds a ConfigMap immediately before cluster creation with information about the installer. This ConfigMap is not present when the user provisions the cluster themselves since it isn't injected until the Terraform variables are generated. This ConfipMap contains the installer version and the name of the invoker (can be overridden with the OPENSHIFT_INSTALL_INVOKER environment variable). This will allow us to determine whether a cluster was user-provisioned or installer- provisioned, whether or not a custom build of the installer was used, and who created the cluster (e.g. Hive, CI).
|
/lgtm /retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, crawford The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@crawford: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Are we backporting this (and #2046) to release-4.1? Or are we expecting 4.2 to come in strongly enough that we won't care about this metric for 4.1? |
|
/cherrypick release-4.1 |
|
@crawford: #1890 failed to apply on top of branch "release-4.1": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
OpenShift telemetry is currently unable to report _how_ a cluster was installed (i.e. user-provisioned vs installer-provisioned). We currently use a heuristic to try to determine this information. This patch adds a ConfigMap immediately before cluster creation with information about the installer. This ConfigMap is not present when the user provisions the cluster themselves since it isn't injected until the Terraform variables are generated. This ConfipMap contains the installer version and the name of the invoker (can be overridden with the OPENSHIFT_INSTALL_INVOKER environment variable). This will allow us to determine whether a cluster was user-provisioned or installer- provisioned, whether or not a custom build of the installer was used, and who created the cluster (e.g. Hive, CI). This commit cherry-picks 253126f (asset/cluster: inject installer info when creating, 2019-06-21, openshift#1890), although it's not a clean pick because of conflicting context in the imports between the master branch and this release-4.1 line [1]. [1]: openshift#1890 (comment)
7 participants
OpenShift telemetry is currently unable to report how a cluster was
installed (i.e. user-provisioned vs installer-provisioned). We currently
use a heuristic to try to determine this information.
This patch adds a ConfigMap immediately before cluster creation with
information about the installer. This ConfigMap is not present when the
user provisions the cluster themselves since it isn't injected until the
Terraform variables are generated. This ConfipMap contains the installer
version and the name of the invoker (can be overridden with the
OPENSHIFT_INSTALL_INVOKER environment variable). This will allow us to
determine whether a cluster was user-provisioned or installer-
provisioned, whether or not a custom build of the installer was used,
and who created the cluster (e.g. Hive, CI).