Skip to content

[WIP] NO-ISSUE: integration tests support for OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE env var #8749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andfasano wants to merge 1 commit into from
Closed

[WIP] NO-ISSUE: integration tests support for OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE env var #8749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions cmd/openshift-install/agent_internal_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,20 @@ func runIntegrationTest(t *testing.T, testFolder string) {
}
}

// Let's get the current release version, so that
// it could be used within the tests
pullspec, err := releaseimage.Default()
if err != nil {
return err
var pullspec string
// If set, let's use $OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE to replace test data
// and also pass it to the testscript environment. It will be usually set in a CI job
// to reference the ephemeral payload release.
if releaseImageOverride, ok := os.LookupEnv("OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE"); ok && releaseImageOverride != "" {
pullspec = releaseImageOverride
e.Vars = append(e.Vars, fmt.Sprintf("OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE=%s", pullspec))
} else {
// Let's get the current release version, so that
// it could be used within the tests
pullspec, err = releaseimage.Default()
if err != nil {
return err
}
}
e.Vars = append(e.Vars, fmt.Sprintf("RELEASE_IMAGE=%s", pullspec))

Expand Down