Skip to content

[WIP] NO-ISSUE: integration tests support for OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE env var #8749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andfasano wants to merge 1 commit into from
Closed

[WIP] NO-ISSUE: integration tests support for OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE env var #8749

andfasano wants to merge 1 commit into from

Conversation

@andfasano
Copy link
Contributor

@andfasano andfasano commented Jul 18, 2024

With this patch it will be possible to let the integration tests to use/reference the ephemeral release payload in a CI job (if set).
Before just the embbeded release pullspec was used, usually something like registry.ci.openshift.org/origin/release:4.17. Even though by definition the integration tests do not deploy any cluster, it wasn't an optimal setup for the tested commands

@andfasano
allow using $OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE during integrat…
3b899dd 
…ion tests execution

This env var will also be set in a CI job to reference the ephemeral payload release
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 18, 2024

@andfasano: This pull request explicitly references no jira issue.

Details

In response to this:

With this patch it will be possible to let the integration tests to use/reference the ephemeral release payload in a CI job (if set).
Before just the embbeded release pullspec was used, usually something like registry.ci.openshift.org/origin/release:4.17. Even though by definition the integration tests do not deploy any cluster, it wasn't an optimal setup for the tested commands

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 18, 2024
@andfasano
Copy link
Contributor Author

andfasano commented Jul 18, 2024

cc @patrickdillon @r4f4

@openshift-ci openshift-ci bot requested review from jhixson74 and r4f4 July 18, 2024 15:13
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andfasano. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@r4f4
Copy link
Contributor

r4f4 commented Jul 18, 2024

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2024

@r4f4: The following commands are available to trigger required jobs:

  • /test agent-integration-tests
  • /test altinfra-images
  • /test aro-unit
  • /test e2e-agent-compact-ipv4
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-edge-zones-manifest-validation
  • /test e2e-aws-ovn-upi
  • /test e2e-azure-ovn
  • /test e2e-azure-ovn-upi
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-upi
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack-ovn
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-ovn-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test okd-images
  • /test okd-unit
  • /test okd-verify-codegen
  • /test openstack-manifests
  • /test shellcheck
  • /test terraform-images
  • /test terraform-verify-vendor
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test altinfra-e2e-aws-custom-security-groups
  • /test altinfra-e2e-aws-ovn
  • /test altinfra-e2e-aws-ovn-fips
  • /test altinfra-e2e-aws-ovn-imdsv2
  • /test altinfra-e2e-aws-ovn-localzones
  • /test altinfra-e2e-aws-ovn-proxy
  • /test altinfra-e2e-aws-ovn-public-ipv4-pool
  • /test altinfra-e2e-aws-ovn-shared-vpc
  • /test altinfra-e2e-aws-ovn-shared-vpc-local-zones
  • /test altinfra-e2e-aws-ovn-shared-vpc-wavelength-zones
  • /test altinfra-e2e-aws-ovn-single-node
  • /test altinfra-e2e-aws-ovn-wavelengthzones
  • /test altinfra-e2e-azure-capi-ovn
  • /test altinfra-e2e-azure-ovn-shared-vpc
  • /test altinfra-e2e-gcp-capi-ovn
  • /test altinfra-e2e-gcp-ovn-byo-network-capi
  • /test altinfra-e2e-gcp-ovn-secureboot-capi
  • /test altinfra-e2e-gcp-ovn-xpn-capi
  • /test altinfra-e2e-ibmcloud-capi-ovn
  • /test altinfra-e2e-nutanix-capi-ovn
  • /test altinfra-e2e-openstack-capi-ccpmso
  • /test altinfra-e2e-openstack-capi-ccpmso-zone
  • /test altinfra-e2e-openstack-capi-dualstack
  • /test altinfra-e2e-openstack-capi-dualstack-upi
  • /test altinfra-e2e-openstack-capi-dualstack-v6primary
  • /test altinfra-e2e-openstack-capi-externallb
  • /test altinfra-e2e-openstack-capi-nfv-intel
  • /test altinfra-e2e-openstack-capi-ovn
  • /test altinfra-e2e-openstack-capi-proxy
  • /test altinfra-e2e-powervs-capi-ovn
  • /test altinfra-e2e-vsphere-capi-multi-vcenter-ovn
  • /test altinfra-e2e-vsphere-capi-ovn
  • /test altinfra-e2e-vsphere-capi-static-ovn
  • /test altinfra-e2e-vsphere-capi-zones
  • /test azure-ovn-marketplace-images
  • /test e2e-agent-compact-ipv4-appliance-diskimage
  • /test e2e-agent-compact-ipv4-none-platform
  • /test e2e-agent-ha-dualstack
  • /test e2e-agent-sno-ipv4-pxe
  • /test e2e-agent-sno-ipv6
  • /test e2e-aws-overlay-mtu-ovn-1200
  • /test e2e-aws-ovn-edge-zones
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-heterogeneous
  • /test e2e-aws-ovn-imdsv2
  • /test e2e-aws-ovn-proxy
  • /test e2e-aws-ovn-public-subnets
  • /test e2e-aws-ovn-shared-vpc-custom-security-groups
  • /test e2e-aws-ovn-shared-vpc-edge-zones
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-ovn-workers-rhel8
  • /test e2e-aws-upi-proxy
  • /test e2e-azure-ovn-resourcegroup
  • /test e2e-azure-ovn-shared-vpc
  • /test e2e-azurestack
  • /test e2e-azurestack-upi
  • /test e2e-crc
  • /test e2e-external-aws
  • /test e2e-external-aws-ccm
  • /test e2e-gcp-ovn-byo-vpc
  • /test e2e-gcp-ovn-xpn
  • /test e2e-gcp-secureboot
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi-xpn
  • /test e2e-ibmcloud-ovn
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi-ovn
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-swapped-hosts
  • /test e2e-metal-ipi-ovn-virtualmedia
  • /test e2e-metal-single-node-live-iso
  • /test e2e-nutanix-ovn
  • /test e2e-openstack-ccpmso
  • /test e2e-openstack-ccpmso-zone
  • /test e2e-openstack-dualstack
  • /test e2e-openstack-dualstack-upi
  • /test e2e-openstack-externallb
  • /test e2e-openstack-nfv-intel
  • /test e2e-openstack-proxy
  • /test e2e-vsphere-ovn-techpreview
  • /test e2e-vsphere-ovn-upi-zones
  • /test e2e-vsphere-ovn-zones
  • /test e2e-vsphere-ovn-zones-techpreview
  • /test e2e-vsphere-static-ovn
  • /test okd-e2e-agent-compact-ipv4
  • /test okd-e2e-agent-ha-dualstack
  • /test okd-e2e-agent-sno-ipv6
  • /test okd-e2e-aws-ovn
  • /test okd-e2e-aws-ovn-upgrade
  • /test okd-e2e-gcp
  • /test okd-e2e-gcp-ovn-upgrade
  • /test okd-e2e-vsphere
  • /test okd-scos-e2e-aws-ovn
  • /test okd-scos-images
  • /test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-installer-master-altinfra-images
  • pull-ci-openshift-installer-master-aro-unit
  • pull-ci-openshift-installer-master-e2e-aws-ovn
  • pull-ci-openshift-installer-master-e2e-aws-ovn-heterogeneous
  • pull-ci-openshift-installer-master-gofmt
  • pull-ci-openshift-installer-master-golint
  • pull-ci-openshift-installer-master-govet
  • pull-ci-openshift-installer-master-images
  • pull-ci-openshift-installer-master-okd-unit
  • pull-ci-openshift-installer-master-okd-verify-codegen
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-unit
  • pull-ci-openshift-installer-master-verify-codegen
  • pull-ci-openshift-installer-master-verify-vendor
  • pull-ci-openshift-installer-master-yaml-lint
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@r4f4
Copy link
Contributor

r4f4 commented Jul 18, 2024

/test agent-integration-tests

@r4f4
Copy link
Contributor

r4f4 commented Jul 18, 2024

It seems the override is never set for the agent-integration-tests.

@andfasano andfasano mentioned this pull request Jul 18, 2024
Merged
@andfasano
Copy link
Contributor Author

andfasano commented Jul 18, 2024

It seems the override is never set for the agent-integration-tests.

Yeah, about to push another PR for that but was delayed.

Requires: openshift/release#54542

@pawanpinjarkar
Copy link
Contributor

pawanpinjarkar commented Jul 19, 2024

/retest-required

2 similar comments
@pawanpinjarkar
Copy link
Contributor

pawanpinjarkar commented Jul 22, 2024

/retest-required

@pawanpinjarkar
Copy link
Contributor

pawanpinjarkar commented Jul 22, 2024

/retest-required

@r4f4
Copy link
Contributor

r4f4 commented Jul 22, 2024

It seems the pull secret is missing:

level=error msg=error: unable to read image registry.build02.ci.openshift.org/ci-op-hn7n51y5/release@sha256:ca82feb23908e4cff1dbe8fce0d84b37f2c943e4d6facbcd15ac70910bc59c9e: unauthorized: authentication required

@andfasano
Copy link
Contributor Author

andfasano commented Jul 23, 2024

It seems the pull secret is missing:

level=error msg=error: unable to read image registry.build02.ci.openshift.org/ci-op-hn7n51y5/release@sha256:ca82feb23908e4cff1dbe8fce0d84b37f2c943e4d6facbcd15ac70910bc59c9e: unauthorized: authentication required

Yes, to make it work we'll still need to:

  1. Mount the CI pull secret in the job, ie:
credentials:
      - mount_path: /var/secrets/registry-pull-secret
        name: registry-pull-credentials
        namespace: test-credentials

  1. export it in an env var, ie $AUTH_FILE

  2. Modify the runIntegrationTest method to template the generated install-config.yaml ps field with the content of the referenced file from $AUTH_FILE - if set

@andfasano andfasano changed the title NO-ISSUE: integration tests support for OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE env var [WIP] NO-ISSUE: integration tests support for OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE env var Jul 23, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2024
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Jul 23, 2024

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2024
@pawanpinjarkar
Copy link
Contributor

pawanpinjarkar commented Jul 31, 2024

/close as it is handled via #8789

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-heterogeneous 3b899dd link false /test e2e-aws-ovn-heterogeneous
ci/prow/agent-integration-tests 3b899dd link true /test agent-integration-tests
ci/prow/integration-tests 3b899dd link true /test integration-tests
ci/prow/e2e-aws-ovn 3b899dd link true /test e2e-aws-ovn
ci/prow/artifacts-images 3b899dd link true /test artifacts-images
ci/prow/integration-tests-nodejoiner 3b899dd link true /test integration-tests-nodejoiner

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@andfasano
Copy link
Contributor Author

andfasano commented Oct 4, 2024

handled via #8789

@andfasano andfasano closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@r4f4 r4f4 Awaiting requested review from r4f4

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andfasano @openshift-ci-robot @r4f4 @pawanpinjarkar @openshift-merge-robot