Skip to content

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Jan 2, 2019

This adds a new image with installer built to support libvirt. This is
required for BYOR installation currently

Related to #955

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 2, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: smarterclayton

If they are not already assigned, you can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This adds a new image with installer built to support libvirt. This is
required for bring-your-own RHCOS installation currently
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws c460795 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@crawford
Copy link
Contributor

crawford commented Jan 4, 2019

Is this still needed now that #982 has merged?

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 4, 2019

@crawford probably not, at least not for BYOR team, unless some other team needs a CI-built container for libvirt. Feel free to close it

@crawford
Copy link
Contributor

crawford commented Jan 4, 2019

Okay. Thanks anyway for the effort.

/close

@openshift-ci-robot
Copy link
Contributor

@crawford: Closed this PR.

Details

In response to this:

Okay. Thanks anyway for the effort.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants