Skip to content

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Jan 2, 2019

Requires openshift/installer#978 to be merged first

A different image is currently required for BYOR case to work in CI. This adds a new installer-libvirt image and renames existing libvirt-installer to installer-libvirt-nested to avoid confusion.

PTAL @crawford @sallyom

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 2, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: abhinavdahiya

If they are not already assigned, you can assign the PR to them by writing /assign @abhinavdahiya in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@droslean
Copy link
Member

droslean commented Jan 9, 2019

/test all

@crawford
Copy link
Contributor

crawford commented Jan 9, 2019

openshift/installer#978 has been closed. I assume we can close this as well.

/close

@openshift-ci-robot
Copy link
Contributor

@crawford: Closed this PR.

Details

In response to this:

openshift/installer#978 has been closed. I assume we can close this as well.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs vrutkovs deleted the byor-40-installer-libvirt branch January 27, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants