Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #2135

/assign wangke19

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-37706 has been cloned as Jira Issue OCPBUGS-56834. Will retitle bug to link to clone.
/retitle [release-4.18] OCPBUGS-56834: allow TLS1.3 or modern profile to be specified

In response to this:

This is an automated cherry-pick of #2135

/assign wangke19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-37706: allow TLS1.3 or modern profile to be specified [release-4.18] OCPBUGS-56834: allow TLS1.3 or modern profile to be specified May 29, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 29, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-56834, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-37706 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-37706 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #2135

/assign wangke19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k, tkashem and wangke19 May 29, 2025 03:53
@wangke19
Copy link

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-tls-13 #2315 openshift/cluster-etcd-operator#1428

@openshift-ci
Copy link

openshift-ci bot commented May 29, 2025

@wangke19: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@wangke19
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, wangke19
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@p0lyn0mial
Copy link

There’s still no e2e test that automatically validates the modern profile (openshift/origin#29611), and the periodic job (https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-tls-13) seems to be permanently failing.

Are we confident about back porting the fix?

/cc @jacobsee @dusk125

@openshift-ci openshift-ci bot requested review from dusk125 and jacobsee May 29, 2025 12:42
@wangke19
Copy link

I will take some time to check the root cause for tls13 failed e2e tests.

@p0lyn0mial
Copy link

I will take some time to check the root cause for tls13 failed e2e tests.

Thank you!

Also, I have a question for @jacobsee @dusk125: how do we keep track of failures in the periodic job?

@wangke19
Copy link

Fixed in PR openshift/origin#29911

@wangke19
Copy link

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-tls-13 #2315 openshift/cluster-etcd-operator#1428

@openshift-ci
Copy link

openshift-ci bot commented Jun 19, 2025

@wangke19: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@wangke19
Copy link

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-tls-13 openshift/cluster-etcd-operator#1428 #2315

@openshift-ci
Copy link

openshift-ci bot commented Jun 19, 2025

@wangke19: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@openshift-ci
Copy link

openshift-ci bot commented Jun 19, 2025

@wangke19: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@wangke19
Copy link

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-tls-13 #2315

@openshift-ci
Copy link

openshift-ci bot commented Jun 19, 2025

@wangke19: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@wangke19
Copy link

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-tls-13 openshift/cluster-etcd-operator#1428

@openshift-ci
Copy link

openshift-ci bot commented Jun 19, 2025

@wangke19: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@wangke19
Copy link

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-tls-13 openshift/cluster-etcd-operator#1428

@openshift-ci
Copy link

openshift-ci bot commented Jun 19, 2025

@wangke19: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@wangke19
Copy link

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn openshift/cluster-etcd-operator#1428

@openshift-ci
Copy link

openshift-ci bot commented Jun 19, 2025

@wangke19: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@wangke19
Copy link

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-tls-13 openshift/cluster-etcd-operator#1428

@openshift-ci
Copy link

openshift-ci bot commented Jun 19, 2025

@wangke19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-tls-13

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f841c170-4d40-11f0-8f6e-c22952cd3d6f-0

@wangke19
Copy link

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-tls-13 openshift/cluster-etcd-operator#1428

@openshift-ci
Copy link

openshift-ci bot commented Jun 19, 2025

@wangke19: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@wangke19
Copy link

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-tls-13 openshift/cluster-etcd-operator#1428

@openshift-ci
Copy link

openshift-ci bot commented Jun 19, 2025

@wangke19: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@wangke19
Copy link

Test results of CI job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-tls-13: 96a24535-7a0b-4ad3-adeb-bdf2d9b6a5c9, looks good.

@wangke19
Copy link

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-tls-13 openshift/cluster-etcd-operator#1428

@openshift-ci
Copy link

openshift-ci bot commented Jun 20, 2025

@wangke19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-tls-13

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dc46af30-4db3-11f0-82ac-e8f71330d1dc-0

@wangke19
Copy link

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-tls-13 openshift/cluster-etcd-operator#1428

The test passed.

@wangke19
Copy link

/assign @p0lyn0mial @dusk125 @jacobsee

@openshift-ci
Copy link

openshift-ci bot commented Aug 5, 2025

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wangke19
Copy link

Waiting for openshift/origin#29611 first

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 29, 2025
@wangke19
Copy link

wangke19 commented Dec 9, 2025

/lifecycle stale

@wangke19
Copy link

wangke19 commented Dec 9, 2025

Depends on openshift/origin#30536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants