Skip to content

Conversation

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jun 11, 2021
@openshift-ci-robot
Copy link

@s-urbaniak: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci openshift-ci bot requested review from deads2k and marun June 11, 2021 10:39
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Jun 11, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 11, 2021

@s-urbaniak: This pull request references Bugzilla bug 1970828, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @barleyer

Details

In response to this:

Bug 1970828: Revert "Bug 1946479: Re-enable BoundServiceAccountTokenVolume disabled by 1.21 rebase"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 11, 2021
@openshift-ci openshift-ci bot requested a review from barleyer June 11, 2021 10:39
@mfojtik
Copy link

mfojtik commented Jun 11, 2021

/override ci/prow/verify-commits

/lgtm
/approve
/hold

(holding for final decision on this by EOD Friday)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jun 11, 2021

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/verify-commits

Details

In response to this:

/override ci/prow/verify-commits

/lgtm
/approve
/hold

(holding for final decision on this by EOD Friday)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 11, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 11, 2021

@s-urbaniak: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/k8s-e2e-gcp 1554acc link /test k8s-e2e-gcp
ci/prow/e2e-aws-fips 1554acc link /test e2e-aws-fips
ci/prow/e2e-gcp-upgrade 1554acc link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@s-urbaniak
Copy link
Author

this can be closed in favor of openshift/oauth-server#80 once the other PR merges.

@s-urbaniak
Copy link
Author

closing in favor of openshift/oauth-server#80

@s-urbaniak s-urbaniak closed this Jun 11, 2021
@s-urbaniak s-urbaniak deleted the revert-714-fix-bound-service-account-token-volume branch June 11, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants