-
Notifications
You must be signed in to change notification settings - Fork 126
Bug 1970828: Revert "Bug 1946479: Re-enable BoundServiceAccountTokenVolume disabled by 1.21 rebase" #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d by 1.21 rebase"
|
@s-urbaniak: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
@s-urbaniak: This pull request references Bugzilla bug 1970828, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/verify-commits /lgtm (holding for final decision on this by EOD Friday) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/verify-commits DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@s-urbaniak: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
this can be closed in favor of openshift/oauth-server#80 once the other PR merges. |
|
closing in favor of openshift/oauth-server#80 |
projected service account tokens break assumptions in https://github.com/openshift/oauth-server/blob/205d6493b5e8017e4187c4b358bc6fec37a835ff/vendor/github.com/openshift/library-go/pkg/oauth/oauthserviceaccountclient/oauthclientregistry.go#L468-L482
Reverts #714