Bug 1970828: fix projected service accounts as oauth-client #80
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/assign @deads2k this could work, the work with audiences feels a little wobbly |
|
/retitle Bug 1970828: fix projected service accounts as oauth-client |
openshift-ci
bot
changed the title
openshift-ci
bot
added
bugzilla/severity-urgent
|
@stlaz: This pull request references Bugzilla bug 1970828, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
1 similar comment
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, s-urbaniak, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| return false | ||
| } | ||
| return true | ||
| } |
There was a problem hiding this comment.
follow-up nit:
if tok == nil {
return false
}
public := &jwt.Claims{}
...
There was a problem hiding this comment.
(unindent the if-block)
|
/test e2e-agnostic-upgrade |
|
@stlaz: All pull requests linked via external trackers have merged: Bugzilla bug 1970828 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build oauth-server-container-v4.8.0-202311261141.p0.g374e2ee.assembly.stream for distgit oauth-server. |
5 participants
Uh oh!
There was an error while loading. Please reload this page.