Skip to content

Conversation

@jottofar
Copy link
Contributor

Both the oc client application and the CVO do image release verification. Image release verification was recently added to the oc client and at that time any code required was simply copied from the CVO were it was originally developed. This change moves the code required for image release verification, the CVO package verify, from the CVO into library-go for reuse by CVO and the oc client application and applies any required changes to make it reusable by both.

Both the oc client application and the CVO do image release
verification. Image release verification was recently added to the oc
client and at that time any code required was simply copied from the CVO
were it was originally developed. This change moves the code required
for image release verification, the CVO package verify, from the CVO
into library-go for reuse by CVO and the oc client application and
applies any required changes to make it reusabe by both.
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jottofar
To complete the pull request process, please assign sttts
You can assign the PR to them by writing /assign @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jottofar
Copy link
Contributor Author

/assign @wking

@wking
Copy link
Member

wking commented Aug 24, 2020

/close

Issue with me approving #837 was the vendor bump.

@openshift-ci-robot
Copy link

@wking: Closed this PR.

Details

In response to this:

/close

Issue with me approving #837 was the vendor bump.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants