Skip to content

Bug 1809195: test/extended/prometheus: Require HTTPS for the CVO #25135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 2 commits into from
Jun 19, 2020
Merged

Bug 1809195: test/extended/prometheus: Require HTTPS for the CVO #25135

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d710865
test/extended/prometheus: During transition, allow HTTP(S) for CVO
wking Jun 17, 2020
18dd62c
test/extended/prometheus: Require HTTPS for the CVO
wking Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test/extended/prometheus: Require HTTPS for the CVO 
Now that the CVO pull request has landed, require HTTPS going forward.
  • Loading branch information
@wking
wking committed Jun 17, 2020
commit 18dd62ca3b74c14d3c9b3aafe8ce9571da3bbc64
3 changes: 1 addition & 2 deletions test/extended/prometheus/prometheus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,7 @@ var _ = g.Describe("[sig-instrumentation] Prometheus", func() {
targets.Expect(labels{"job": "kube-state-metrics"}, "up", "^https://.*/metrics$"),

// Cluster version operator
// TODO: require HTTPS once https://github.com/openshift/cluster-version-operator/pull/385 lands
targets.Expect(labels{"job": "cluster-version-operator"}, "up", "^https?://.*/metrics$"),
targets.Expect(labels{"job": "cluster-version-operator"}, "up", "^https://.*/metrics$"),
)
}

Expand Down