Bug 1809195: test/extended/prometheus: Require HTTPS for the CVO #25135
Conversation
Currently the master CVO serves only HTTP. There is a pull request in flight (linked from the Go comment) to declare an HTTPS target in the ServiceMonitor. Allowing both, as I'm doing in this commit, will allow us to land this test-suite change now. Then we can land the CVO pull request. And then we can drop the '?' to require HTTPS going forward.
Now that the CVO pull request has landed, require HTTPS going forward.
openshift-ci-robot
added
the
do-not-merge/hold
wking
changed the title
openshift-ci-robot
added
the
bugzilla/severity-high
|
@wking: This pull request references Bugzilla bug 1809195, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulfantom, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/hold cancel CVO PR merged |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@wking: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@wking: All pull requests linked via external trackers have merged: openshift/origin#25135, openshift/origin#25134, openshift/cluster-version-operator#385, openshift/cluster-version-operator#358. Bugzilla bug 1809195 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
Now that the CVO pull request has landed, require HTTPS going forward (firming up the flexible behavior from #25134).
/hold
Until openshift/cluster-version-operator#385 actually lands.